Support multiple features declaring same properties #71106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
Feature:Security/Feature Controls
legrego
commented
Jul 8, 2020
| if (!acc.has(section[0])) { | ||
| acc.set(section[0], []); | ||
| } | ||
| acc.get(section[0])!.push(...section[1]); |
There was a problem hiding this comment.
note: duplicate entries are technically possible here, but it seems tolerable given the lifetime and size of this array
|
Pinging @elastic/kibana-security (Team:Security) |
|
ACK: will review here shortly. |
jportner
approved these changes
Jul 8, 2020
x-pack/plugins/spaces/server/capabilities/capabilities_switcher.test.ts
Outdated
Show resolved
Hide resolved
…r.test.ts Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 9, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego
added a commit
that referenced
this pull request
Jul 9, 2020
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 10, 2020
…11y-overlay * 'master' of github.com:elastic/kibana: (33 commits) address index templates feedback (elastic#71353) Upgrade EUI to v26.3.1 (elastic#70243) [build] Creates Linux aarch64 archive (elastic#69165) [SIEM][Detection Engine] Fixes skipped tests (elastic#71347) [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911) [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886) [ML] DF Analytics: stop status polling when job stopped (elastic#71159) [SIEM][CASE] IBM Resilient Connector (elastic#66385) jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI Deduplication of entries and items before sending to endpoint (elastic#71297) [services/remote/webdriver] fix eslint error (elastic#71346) send slack notifications on visual baseline failures fix visual regression job (elastic#70999) [Ingest Manager] Add schema to usageCollector. (elastic#71219) [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279) [Ingest Manager] Fix limited packages incorrect response (elastic#71292) Support multiple features declaring same properties (elastic#71106) [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183) [DOCS] Clarify trial subscription levels (elastic#70636) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Feature Controls was first introduced, there was an assumption that management, catalogue, and app entries would be owned by a single feature. This is mostly still the case, but Alerting is introducing an Alerts Management screen which is visible when any other alerting-enabled feature is enabled.
The current logic hides management, catalogue, and app entries if a single "owning" feature is disabled. This PR revises this logic so that these entries are only disabled if all "owning" features are disabled.
While alerting's requirements only need this behavior change for management entries, it felt prudent to make catalogue and app entries consistent.
Resolves #71091
cc @gmmorris