Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional test] Increase the timeout to click new vis function #71226

Merged
merged 4 commits into from
Jul 13, 2020
Merged

[Functional test] Increase the timeout to click new vis function #71226

merged 4 commits into from
Jul 13, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 9, 2020 •
edited
Loading

Summary

Fixes #71209

Checklist

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula
Copy link
Contributor Author

stratoula commented Jul 9, 2020 •
edited
Loading

Here the vis list has already some visualizations. So it shouldn't search for createVisualizationPromptButton . It should search for newItemButton . For this reason I added a 5000 timeout to check if the newItemButton exists and as I have seen that this function fails in general some times I also increased the retry timeout to 20000.
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/580/

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review July 13, 2020 06:43
@stratoula stratoula added v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 13, 2020
@stratoula stratoula requested a review from dmlemeshko July 13, 2020 06:45
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula added the Feature:TSVB TSVB (Time Series Visual Builder) label Jul 13, 2020
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dmlemeshko
dmlemeshko approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@stratoula stratoula merged commit 0684751 into elastic:master Jul 13, 2020
@stratoula stratoula mentioned this pull request Jul 13, 2020
Merged
stratoula added a commit to stratoula/kibana that referenced this pull request Jul 13, 2020
@stratoula @elasticmachine
[Functional test] Increase the timeout to click new vis function (ela…
6e8c670 
…stic#71226)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request Jul 13, 2020
@stratoula @elasticmachine
[Functional test] Increase the timeout to click new vis function (#71226
e2bb566 
) (#71440)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 13, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
cd0522e 
* master: (28 commits)
  skip flaky suite (elastic#71361)
  [Ingest Manager] Add UI to enroll standalone agent (elastic#71288)
  Node options from cfg file for production (elastic#62468)
  [APM] Improvements to the ML Settings page (elastic#71309)
  add old .chromium to gitignore to prevent it from being accidentally committed
  [Ingest Manager] Simplify add/edit package config (integration) form (elastic#71187)
  Ensure Other bucket works on scripted fields. (elastic#71329)
  [APM] Anomaly detection setup link with alert if job doesn't exist (elastic#71229)
  [APM] Anomaly detection integration with transaction duration chart (elastic#71230)
  inclusive language (elastic#71438)
  [Ingest Manager] During fleet setup create an enrollment for every config (elastic#71308)
  Improvements to our developer guide (elastic#67764)
  [SIEM][Detections] Fixes index patterns order (elastic#71270)
  [Metrics + Logs UI] Add test for logs and metrics telemetry (elastic#70858)
  [Maps] Inclusive language (elastic#71427)
  [Logs UI] Unskip log highlight api integration test (elastic#71058)
  [Security_Solution][Resolver] Style adjustments per UX (elastic#71179)
  [Functional test] Increase the timeout to click new vis function (elastic#71226)
  [Discover] Migrate async import of embeddable factory to actual embeddable (elastic#70920)
  fix overflow (elastic#70723)
  ...
@stratoula stratoula mentioned this pull request Jul 27, 2020
Closed
This was referenced Jul 27, 2020
Closed
Closed
@stratoula stratoula mentioned this pull request Aug 17, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
Feature:Functional Testing Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@stratoula @kibanamachine @dmlemeshko @LeeDr @elasticmachine