-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump apollo-server-core package version #71393
Conversation
This PR as-is fails the type checker. Notes:
|
@jasonrhodes @rylnd both of your names come up in the git blame when looking at the Side note: the functional test failure appears to be unrelated/flaky. |
@jportner do we need this for v6.8.12? If yes, it needs to get in by EOD 2020-08-11 |
@LeeDr no, thanks for pointing it out, I’ll update the tags |
@elasticmachine merge upstream |
merge conflict between base and head |
Hmm that merge didn't go well 😅 |
Note, this was being included as a transitive dependency via apollo-server-hapi, but that isn't being used directly anymore, so I got rid of that package entirely. We only need apollo-server-core
10cb67c
to
f469057
Compare
Force push FTW 💪 |
💔 Build Failed
Failed CI Steps
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/feature_controls/infrastructure_security·ts.InfraOps app feature controls infrastructure security global infrastructure all privileges infrastructure landing page without data shows 'Change source configuration' buttonStandard Out
Stack Trace
X-Pack API Integration Tests.x-pack/test/api_integration/apis/metrics_ui/log_entries·ts.apis MetricsUI Endpoints log entry apis /log_entries/entries with a configured source "before all" hook for "returns the configured columns"Standard Out
Stack Trace
X-Pack API Integration Tests.x-pack/test/api_integration/apis/metrics_ui/log_entries·ts.apis MetricsUI Endpoints log entry apis /log_entries/entries with a configured source "before all" hook for "returns the configured columns"Standard Out
Stack Trace
and 1 more failures, only showing the first 3. Metrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
@rylnd are you all still using apollo? We are close to having it removed in Metrics and then we no longer need this bump. I'm curious if I should push hard on that or if we should just bite the bullet and bump for the security. The work has been pushed back multiple times on our side. |
@jasonrhodes while most of our graphQL endpoints have been replaced with search strategy usage, we've still got several relating to timelines. I don't believe there's any technical blocker there (@XavierM can correct me) but migrating those likely won't happen before 7.12. |
Hey @rylnd, It looks like there is only one place left where we still directly use I tried to do it myself, but my GraphQL/Appolo knowledge isn't enough to be sure that I fix your code properly. |
Overview:
1.3.6
->2.19.0
Note, this was being included as a transitive dependency via apollo-server-hapi, but that isn't being used directly anymore, so I got rid of that package entirely. We only need apollo-server-core.