Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[field formatters] IP should return - on null or undefined #7257

Merged
merged 1 commit into from
May 20, 2016

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 20, 2016

Null ip addresses were turning into 0.0.0.0 after running through the ip formatter. This changes null/undefined to render as -.

POST /foo/bar
PUT /foo/bar/_mapping
{
  "properties": {
    "test": {
      "type": "ip"
    }
  }
}
POST /foo/bar/1
{
  "test": "192.168.1.1"
}
POST /foo/bar/2
{
  "test": null
}

Closes #7182

@LeeDr
Copy link

LeeDr commented May 20, 2016

LGTM

@jbudz jbudz merged commit a11a86e into elastic:master May 20, 2016
This was referenced May 20, 2016
jbudz added a commit that referenced this pull request May 20, 2016
---------

**Commit 1:**
[field formatters] IP should return - on null or undefined

* Original sha: 959d9cf
* Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-20T18:34:57Z
jbudz added a commit that referenced this pull request May 20, 2016
---------

**Commit 1:**
[field formatters] IP should return - on null or undefined

* Original sha: 959d9cf
* Authored by Jonathan Budzenski <jbudz@users.noreply.github.com> on 2016-05-20T18:34:57Z
jbudz added a commit that referenced this pull request May 20, 2016
jbudz added a commit that referenced this pull request May 20, 2016
@epixa epixa added v4.5.4 and removed v4.5.2 labels Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants