Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Stop indexing saved object fields. #72787

Merged
merged 1 commit into from
Jul 22, 2020
Merged

[Uptime] Stop indexing saved object fields. #72787

merged 1 commit into from
Jul 22, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Jul 22, 2020 •
edited
Loading

Fixes #72782 . None of our saved object fields need indexing.

Checklist

@andrewvc andrewvc added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 labels Jul 22, 2020
@andrewvc andrewvc requested a review from justinkambic July 22, 2020 01:38
@andrewvc andrewvc requested a review from a team as a code owner July 22, 2020 01:38
@andrewvc andrewvc self-assigned this Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@andrewvc andrewvc added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes labels Jul 22, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

Saved Objects .kibana field count

id value diff baseline
uptime-dynamic-settings - -4 4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic
justinkambic approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested this locally and settings seemed to work fine, as expected.

@andrewvc andrewvc merged commit 0ed55f2 into elastic:master Jul 22, 2020
@andrewvc andrewvc deleted the stop-indexing-unnecessary-fields branch July 22, 2020 16:16
@andrewvc andrewvc mentioned this pull request Jul 22, 2020
Merged
andrewvc added a commit that referenced this pull request Jul 22, 2020
@andrewvc
[Uptime] Stop indexing saved object fields. (#72787) (#72897)
a61fb04 
Fixes #72782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@andrewvc andrewvc

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] Stop indexing saved object fields
4 participants
@andrewvc @elasticmachine @kibanamachine @justinkambic