Reset chrome fields while switching an app #73064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulemanof
added
release_note:skip
|
@elasticmachine merge upstream |
mshustov
reviewed
Jul 27, 2020
| @@ -157,6 +157,11 @@ export class ChromeService { | |||
| const recentlyAccessed = await this.recentlyAccessed.start({ http }); | |||
| const docTitle = this.docTitle.start({ document: window.document }); | |||
|
|
|||
| // erase the help menu extension from previous app while switching to a next app | |||
| application.currentAppId$.subscribe(() => { | |||
| helpExtension$.next(undefined); | |||
There was a problem hiding this comment.
- Shouldn't we reset all the Chrome fields then? Badge, Breadcrumbs, etc.
- It implicitly enforces calling order for
navigationandsetHelpExtension. @joshdover should we make this logic explicit? For example, we can move some Chrome params into theApplicationinterface?
There was a problem hiding this comment.
- Shouldn't we reset all the Chrome fields then? Badge, Breadcrumbs, etc.
- It implicitly enforces calling order for
navigationandsetHelpExtension. @joshdover should we make this logic explicit? For example, we can move some Chrome params into theApplicationinterface?
- Good point, I would also do this on switching an app.
Especially since I still see couple of places when a pagetitleis not changed after navigating to any app, or such a PR's like Add doc titles to ES UI apps #71045 , wherechrome.docTitle.reset()is manually called on application destroy.
So doing it once after switching to any app would close other issues. - I was also under assumption to set default chrome params explicitly in
navigateToApp, but discovered thatchromeservice depends onapplicationone.
So, the other implementation way would cause significant code changes.
I'm excited to receive @joshdover opinion! 🙂
There was a problem hiding this comment.
- Yes, let's go ahead and do those for the chrome items that make sense.
- I agree this would be much better. I think it would be best to split that change into two phases where we first introduce the new API, separately migrate each usage of the existing imperative APIs, and then remove the imperative APIs. This could be done as a different issue / PR.
There was a problem hiding this comment.
@joshdover Should I expand this PR with other chrome items reset, or close it in favor of new API ?
There was a problem hiding this comment.
Should I expand this PR with other chrome items reset, or close it in favor of new API ?
We can fix it here quickly and refactor chrome service after. Another complain: #72671
but let's wait for @joshdover opinion
There was a problem hiding this comment.
Yes I agree, let's go ahead and do the quick fix now in this PR and refactor later.
|
@elasticmachine merge upstream |
…a into fix/erase_help_extension
sulemanof
changed the title
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Aug 24, 2020
Sure! Done! |
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
sulemanof
added a commit
that referenced
this pull request
Aug 27, 2020
* Reset chrome help extension while switching an app * Reset other chrome fields * Set docTitle in saved objects app * Add unit tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #72896
Fixes #72671
Initial issue description:
Help menu not resetting on navigating to Kibana home for some apps
Actually, the problem is also related to switching the apps, which don't have its own chrome fields (e.x. help menu extension, badge, breadcrumbs, etc), so there is a previous one always appear. (e.x. go from
VisualizetoDev Tools, or fromDashboardtoStack Management).So I put the subscription on
application.currentAppId$to erase the previous chrome fieldsChecklist
Delete any items that are not applicable to this PR.
For maintainers