Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] PR #6077 to 4.x - Settings sections registry #7363

Merged
merged 4 commits into from
Jun 6, 2016

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Jun 3, 2016

Blocked by #7359

Adds Setting Registry to 4.x, backport of #6077

w33ble added 4 commits June 2, 2016 11:42
add tests for render_directive

sinon asserts, null instead of false
consume navbar directive
used anywhere the navbar is being used currently
navbar directive tests
allow custom settings sections from plugins

Use settings sections registry to display settings sections

Ensure settings sections load in order

Change to use _.constant instead of () => {}

move require statement to top

remove sections file from autoloader
@epixa epixa merged commit 6979734 into elastic:4.x Jun 6, 2016
@epixa epixa changed the title [Backport] PR #6077 to 4.x [Backport] PR #6077 to 4.x - Settings sections registry Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants