[Uptime] One click simple monitor down alert #73835
Conversation
|
@justinkambic i have removed delete action from expanded list to keep things simple. |
| const { actionTypeId: type } = data?.find((dt) => dt.id === value) ?? {}; | ||
| return ( | ||
| <EuiText size="s"> | ||
| <EuiIcon type={getActionTypeIcon(type as string)} /> <span>{label}</span> |
There was a problem hiding this comment.
I took a look to see if this can be done in a more dynamic way (once plugins start adding their own 3rd party action types) and I think using the actionTypeRegistry exposed by the triggers_actions_ui plugin's start contract may do the trick? Let me know!
startPlugins.triggers_actions_ui.actionTypeRegistry.get(type as string).iconClass
There was a problem hiding this comment.
done, this looks good
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
|
Flaky test runner https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/819/ |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
* WIP * added anomaly alert * update types * update types * update * types * types * update ML part * update ML part * update ML part * unnecessary change * icon for disable * update test * update api * update labels * resolve conflicts * fix types * fix editing alert * fix types * added actions column * added code to add alert * update anomaly message * added anomaly alert test * update * update type * fix ml legacy scoped client * update * WIP * fix conflict * added aria label * Added deleteion loading * fix type * update * update tests * update * update type * fix types * WIP * added enabled alerts section * add data * update * update tests * fix test * update i18n * update i18n * update i18n * fix * update message * update * update * update * revert * update types * added component * update test * incorporate PR feedback * fix focus * update drawer * handle edge case * improve btn text * improve btn text * use switch instead of icons * update snapshot * use compressed form * fix type * update snapshot * update snapshot * update test * update test * PR feedback * fix test and type * remove delete action * remove unnecessary function Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
Summary
Fixes: elastic/uptime#242
Looking for some feedback on functionality. Did this as part of experiment while working on anomaly alert.
Added the ability to configure simple down alert on each monitor by simple one icon.
User will be able to enable/disable alert by clicking icons.
For once they will have to define default alert connector in uptime settings.
User should receive alert once monitor is down like this , containing monitor info, url, observer location and latest error.
server log [14:30:22.205] [info][actions][actions][plugins] Server log: Always Down Local Port with url tcp://localhost:18278 is down from London. The latest error message: dial tcp 127.0.0.1:18278: connect: connection refusedAnother addition is that all enabled alerts for a specific monitor will be displayed in expanded list, by clicking user can do to alert ui and edit those or can delete directly.
User will be able to add connectors from flyout in settings