Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][tech-debt] Fix SVG not shrinking vertically properly #73867

Merged
merged 2 commits into from
Jul 30, 2020
Merged

[Canvas][tech-debt] Fix SVG not shrinking vertically properly #73867

merged 2 commits into from
Jul 30, 2020

Conversation

clintandrewhall
Copy link
Contributor

Summary

Fixes #32108

With a non-zero line-height, and SVG will be automatically padded vertically once the size of the element is smaller than that line-height. This fixes that (long-standing) issue.

I also decided to remove the debounce call from render_with_fn. It makes sizing SVGs "stuttery". We should find a conditional method of debouncing for particular elements, rather than all elements:

Before

Jul-30-2020 15-35-51

After

Jul-30-2020 15-51-37

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.10.0 labels Jul 30, 2020
@clintandrewhall clintandrewhall requested a review from a team as a code owner July 30, 2020 19:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

crob611
crob611 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Agree we should figure out some way to allow that debounce in the render.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
canvas 1189 -129 1318

async chunks size

id value diff baseline
canvas 1.4MB -143.5KB 1.5MB

page load bundle size

id value diff baseline
canvas 1.4MB +27.0B 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 18795b2 into elastic:master Jul 30, 2020
@clintandrewhall clintandrewhall deleted the tech-debt/fix-32108 branch July 30, 2020 23:10
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Jul 30, 2020
@clintandrewhall @elasticmachine
[Canvas][tech-debt] Fix SVG not shrinking vertically properly (elasti…
27e4efb 
…c#73867)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@clintandrewhall clintandrewhall mentioned this pull request Jul 30, 2020
Merged
@monfera
Copy link
Contributor

monfera commented Jul 30, 2020

Previous debounce removal: https://github.com/elastic/kibana-canvas/pull/910

clintandrewhall added a commit that referenced this pull request Jul 31, 2020
@clintandrewhall @elasticmachine
[7.x] [Canvas][tech-debt] Fix SVG not shrinking vertically properly (#…
f8d54d7 
…73867) (#73904)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
28b1676 
* master: (54 commits)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
ce2ee00 
* master: (38 commits)
  [Discover] Context unskip date nanos functional tests (elastic#73781)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Shapes shift out of the element when vertical size is small
5 participants
@clintandrewhall @elasticmachine @kibanamachine @monfera @crob611