[kbn-storybook] Kill tsdocgen for immediate perf improvement #74059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
reviewed
Aug 3, 2020
|
@streamich Damn typo. Fixed and tested with same command. |
clintandrewhall
added
the
release_note:skip
streamich
approved these changes
Aug 3, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
smith
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Running yarn storybook --site apm:
before:
✨ Done in 738.42s.
739.24 real 961.56 user 63.04 sys
after:
✨ Done in 299.82s.
300.04 real 463.74 user 20.44 sys
yarn storybook apm also fast (I didn't do a before because I know it took a long time, just seeing if it's acceptable; it is!)
Storybook 5.3.19 started │
│ 32 s for manager and 1.35 min for preview
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Aug 6, 2020
…#74059) * [kbn-storybook] Kill tsdocgen for immediate perf improvement * Addressing feedback
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reorganizes the
webpack.config.jsfile to usewebpackMergeand temporarily disables thetsdocgenplugin, (the source of a massive slowdown when writing TS stories). You should see an immediate improvement in startup time.It also makes a slight tweak: if a plugin needs to utilize the
webpackHook, (which none do at the moment, but Canvas will), it will pass not the Storybook config, but the already altered base config fromkbn-storybook. This is a passive change.Effect
Before using
ui_actions_enhanced-1.88m+2.03m=3.91mstartup:After -
19s+28s=47sstartup: