-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip "space with index pattern management disabled" functional test for cloud env #74073
Merged
kertal
merged 4 commits into
elastic:master
from
kertal:kertal-pr-2020-08-03-spaces-functional-test-skip-cloud
Aug 6, 2020
Merged
Skip "space with index pattern management disabled" functional test for cloud env #74073
kertal
merged 4 commits into
elastic:master
from
kertal:kertal-pr-2020-08-03-spaces-functional-test-skip-cloud
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
release_note:skip
Skip the PR/issue when compiling release notes
v7.9.0
v7.10.0
v8.0.0
labels
Aug 3, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
liza-mae
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 6, 2020
…or cloud env (elastic#74073) * Skipped due to occasional flakiness in cloud env, cause by ingest management tests
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 6, 2020
…or cloud env (elastic#74073) * Skipped due to occasional flakiness in cloud env, cause by ingest management tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 6, 2020
* master: (208 commits) Observability Overview fix extra basepath prepend for alerting fetch (elastic#74465) [Lens] Clean and inline disabling of react-hooks/exhaustive-deps eslint rule (elastic#70010) Skip "space with index pattern management disabled" functional test for cloud env (elastic#74073) Filter out non-security jobs when collecting Detections telemetry (elastic#74456) [Security Solution][Test] Enzyme test for related events button (elastic#74411) [SECURITY_SOLUTION] add z-index to get over nav bar (elastic#74427) Rename package configs SO to package policies (elastic#74422) [DOCS] Add Kibana alerts to Stack Monitoring (elastic#73762) skip flaky suite (elastic#71390) [ML] DF Analytics: adds functional tests for edit form (elastic#73885) Rename agent configs SO to agent policies (elastic#74397) [Jenkins] run CI when plugin readmes change (elastic#74388) [Metrics UI] Fix validating Metrics Explorer URL (elastic#74311) fixing encoding issue with \ for enroll command (elastic#74379) [Ingest Manager] Update package registry for testing to f6b01d (elastic#74341) Change experimental message for visualizations (elastic#74354) [Alerting] Reload the Alerts List when alerts are deleted (elastic#73715) [Enterprise Search] Fix/DRY out plugin i18n strings (elastic#74323) update empty prompt in analytics list (elastic#74174) [Task Manager] Correctly handle `running` tasks when calling RunNow and reduce flakiness in related tests (elastic#73244) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Security/Spaces
Platform Security - Spaces feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.9.0
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In cloud ingest management could cause a condition, that creates index patterns in an empty space, that's needed to test
space with index pattern management disabled
. Then the skipped test isn't navigating to home and this causes the test to fail. Therefore it is skipped for cloud environment.Fixes #68849
Checklist