-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Embeddable Panel updateInput Reactivity Issue #74273
Closed
ThomThomson
wants to merge
46
commits into
elastic:master
from
ThomThomson:testing/lensByValueMarcoFix
Closed
[Testing] Embeddable Panel updateInput Reactivity Issue #74273
ThomThomson
wants to merge
46
commits into
elastic:master
from
ThomThomson:testing/lensByValueMarcoFix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid confusion. Added cancel button
…d to determine if newly created or editing
…herit from. This will be used for the add to library and unlink from library actions. Cached the attribute service
ThomThomson
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.10.0
v8.0.0
labels
Aug 4, 2020
⏳ Build in-progress, with failures
Failed CI Steps
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
ignoring request to update branch, pull request is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Embedding
Embedding content via iFrame
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR which combines #70272 & #74253 in order to reproduce the issue where updating the input of an embeddable on a container will not cause a re-render of the embeddable.
In order to reproduce the issue, add a lens embeddable by value, then edit it and save & return. The changes to the embeddable will not be reflected until the page is refreshed.