Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Embeddable Panel updateInput Reactivity Issue #74273

Closed

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Aug 4, 2020

Summary

PR which combines #70272 & #74253 in order to reproduce the issue where updating the input of an embeddable on a container will not cause a re-render of the embeddable.

In order to reproduce the issue, add a lens embeddable by value, then edit it and save & return. The changes to the embeddable will not be reflected until the page is refreshed.

@ThomThomson ThomThomson requested a review from a team August 4, 2020 16:29
@ThomThomson ThomThomson requested a review from a team as a code owner August 4, 2020 16:29
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Aug 4, 2020
@ThomThomson ThomThomson marked this pull request as draft August 4, 2020 16:30
@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 labels Aug 4, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 4, 2020

⏳ Build in-progress, with failures

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611
Copy link
Contributor

dej611 commented Aug 17, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants