Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix how we call grunt with multiple tasks #7461

Closed
wants to merge 2 commits into from
Closed

[WIP] Fix how we call grunt with multiple tasks #7461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a459bb
Fix how we call grunt with multiple tasks
ycombinator Jun 15, 2016
430d70d
Wrap both grunt commands in shell command so we can pass args to each…
ycombinator Jun 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"Tim Sullivan <tim@elastic.co>"
],
"scripts": {
"test": "grunt test; grunt test:visualRegression",
"test": "bash -c 'grunt test $@; grunt test:visualRegression $@' --",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean development has to be done on a system with bash on it, which may be too restrictive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a no go. The dev tasks need to be able to run on windows and such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie doke. Marking this PR as WIP again.

"test:dev": "grunt test:dev",
"test:quick": "grunt test:quick",
"test:browser": "grunt test:browser",
Expand Down