[SECURITY] Bugs css/inspect #74711
Merged
[SECURITY] Bugs css/inspect #74711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Aug 11, 2020
* Fix inspection button when using topN * css left over
| @@ -42,6 +42,9 @@ const FormWrapper = styled.div` | |||
|
|
|||
| padding-top: ${theme.eui.paddingSizes.xl}; | |||
| padding-bottom: ${theme.eui.paddingSizes.xl}; | |||
| .euiFlyout { | |||
| z-index: ${theme.eui.euiZNavigation + 1}; | |||
There was a problem hiding this comment.
@kevinlog FYI
We recently made a similar change in the Management area, but I think we hard-coded the zIndex value. I think this approach here (to use the values provided by theme.eui.euiZNavigation is better, so when we do refactor our implementation (we wanted to make the change so that any euiFlyout in management automatically is set correctly) we use this instead 🙂
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Aug 11, 2020
* Fix inspection button when using topN * css left over
XavierM
added a commit
that referenced
this pull request
Aug 11, 2020
XavierM
added a commit
that referenced
this pull request
Aug 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 11, 2020
* master: (106 commits) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) Bump chalk to 4.1.0 (elastic#73397) Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718) [SECURITY] Bugs css/inspect (elastic#74711) [telemetry] update README to downplay ui_metrics (elastic#74635) Fixed grammar (elastic#74725) [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664) [ILM] Convert node details flyout to TS (elastic#73707) [Ingest Node Pipelines] Sentence-case processor names (elastic#74645) ...
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs
When clicking on top X tooltips the other inspect buttons don't work until you refresh your page;
Navigation of the app on the case configure pages was hiding the title of our connector flyout + adding a bottom border on our navigation app;
Checklist