Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fixed grammar (#74725) #74745

Merged
merged 2 commits into from
Aug 11, 2020
Merged

[7.x] Fixed grammar (#74725) #74745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee02c51
Fixed grammar (#74725)
igoristic Aug 11, 2020
6ce5efc
Delete 0001_lifecycle_setup.md
igoristic Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TYPESCRIPT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ declare module '@elastic/eui' {
1. Open up the file and see how easy it would be to convert to TypeScript.
2. If it's very straightforward, go for it.
3. If it's not and you wish to stay focused on your own PR, get around the error by adding a type definition file in the same folder as the dependency, with the same name.
4. Minimally you will need to type what you are using in your PR. No need to go crazy to fully type the thing or you might be there for awhile depending on what's available.
4. Minimally you will need to type what you are using in your PR. No need to go crazy to fully type the thing or you might be there for a while depending on what's available.

For example:

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data/public/search/search_interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export class SearchInterceptor {
if (this.longRunningToast) return;
this.longRunningToast = this.deps.toasts.addInfo(
{
title: 'Your query is taking awhile',
title: 'Your query is taking a while',
text: getLongQueryNotification({
application: this.deps.application,
}),
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/data_enhanced/public/search/search_interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class EnhancedSearchInterceptor extends SearchInterceptor {
if (this.longRunningToast) return;
this.longRunningToast = this.deps.toasts.addInfo(
{
title: 'Your query is taking awhile',
title: 'Your query is taking a while',
text: getLongQueryNotification({
cancel: this.cancelPending,
runBeyondTimeout: this.runBeyondTimeout,
Expand Down