Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Remove dependency on legacy expressions APIs #74885

Merged
merged 9 commits into from
Aug 18, 2020
Merged

[Canvas] Remove dependency on legacy expressions APIs #74885

merged 9 commits into from
Aug 18, 2020

Conversation

poffdeluxe
Copy link
Contributor

@poffdeluxe poffdeluxe commented Aug 12, 2020 •
edited
Loading

Summary

  • Register functions and types using the updated expressions API
  • Move legacy functions routes responsible for retrieving list of server-side functions as well as evaluating them in batch to Canvas server
  • Move wrapping of server-function list into Canvas
  • Slightly refactored Canvas route tests to make it easier to add router deps

Enables work to continue here #46906

@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.10.0 labels Aug 12, 2020
@poffdeluxe poffdeluxe marked this pull request as ready for review August 13, 2020 22:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@poffdeluxe poffdeluxe requested a review from a team August 14, 2020 18:25
crob611
crob611 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works good for me. Nice job cleaning up those tests as well.

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
canvas 1.4MB -50.0B 1.4MB

page load bundle size

id value diff baseline
canvas 1.3MB +2.6KB 1.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit e6e7354 into elastic:master Aug 18, 2020
@poffdeluxe poffdeluxe deleted the canvas-remove-legacy-interpreter branch August 18, 2020 17:39
@poffdeluxe poffdeluxe mentioned this pull request Aug 18, 2020
Merged
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request Aug 18, 2020
@poffdeluxe @elasticmachine
[Canvas] Remove dependency on legacy expressions APIs (elastic#74885)
6424cef 
* Remove legacy types and function registration

* Pull server interpreter functions routes into Canvas and update them to use new expressions API

* Clean up comment

* Removing boom and doing more cleanup

* Add functions test and refactor other router tests

* Adding a type and refactoring a forgotten test

* more tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
poffdeluxe added a commit that referenced this pull request Aug 18, 2020
@poffdeluxe @elasticmachine
[Canvas] Remove dependency on legacy expressions APIs (#74885) (#75342)
8e12bca 
* Remove legacy types and function registration

* Pull server interpreter functions routes into Canvas and update them to use new expressions API

* Clean up comment

* Removing boom and doing more cleanup

* Add functions test and refactor other router tests

* Adding a type and refactoring a forgotten test

* more tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
@gmmorris
Merge branch 'master' into task-manager/poller-mon
b0f7c0a 
* master: (112 commits)
  [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364)
  Update Node.js to version 10.22.0 (elastic#75254)
  [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953)
  [Discover] Fix histogram cloud tests (elastic#75268)
  Uiactions to navigate to visualize or maps (elastic#74121)
  Use prefix search invis editor field/agg combo box (elastic#75290)
  Fix docs in trigger alerting UI (elastic#75363)
  [SIEM] Fixes search bar Cypress test (elastic#74833)
  Add libnss3.so to Dockerfile template (reporting) (elastic#75370)
  [Discover] Create field_button and add popovers to sidebar (elastic#73226)
  [Reporting] Network Policy: Do not throw from the intercept handler (elastic#75105)
  [Reporting] Increase capture.timeouts.openUrl to 1 minute (elastic#75207)
  Allow routes to specify the idle socket timeout in addition to the payload timeout (elastic#73730)
  [src/dev/build] remove node-version from snapshots (elastic#75303)
  [ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components (elastic#74886)
  [Canvas] Remove dependency on legacy expressions APIs (elastic#74885)
  Skip failing test in CI (elastic#75266)
  [Task Manager] time out work when it overruns in poller (elastic#74980)
  [Drilldowns] misc improvements & fixes (elastic#75276)
  Small README note on bumping memory for builds (elastic#75247)
  ...
@streamich streamich mentioned this pull request Aug 20, 2020
Closed
4 tasks
@lukeelmers lukeelmers mentioned this pull request Aug 20, 2020
Merged
@crob611 crob611 mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poffdeluxe @elasticmachine @kibanamachine @crob611