Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes 'sets and reads the url state for timeline by id' timeline Cypress test #75125

Merged
merged 8 commits into from
Aug 24, 2020
Merged

[SIEM] Fixes 'sets and reads the url state for timeline by id' timeline Cypress test #75125

merged 8 commits into from
Aug 24, 2020

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Aug 16, 2020 •
edited
Loading

Summary

In this PR we are fixing the 'sets and reads the url state for timeline by id' timeline Cypress test.

Before we were getting the timeline id from the url before creating it. That was not completely reliable and made also the test slow. Now we are getting the timeline id from the API call, making the test faster and reliable.

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema MadameSheema self-assigned this Aug 17, 2020
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.10.0 v8.0.0 labels Aug 17, 2020
@MadameSheema MadameSheema marked this pull request as ready for review August 17, 2020 13:36
@MadameSheema MadameSheema requested review from a team as code owners August 17, 2020 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Contributor

When I focused url_state.spec.ts and ran node x-pack/plugins/security_solution/scripts/loop_cypress_tests.js 10, it failed 1 out of 10 times with the following error:

assertion-error

Cypress captured the following screenshot when the test failed:

url state -- sets and reads the url state for timeline by id (failed)

andrew-goldstein
andrew-goldstein approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this test @MadameSheema!
Tested locally by focusing url_state.spec.ts and running node x-pack/plugins/security_solution/scripts/loop_cypress_tests.js 10 to test for flakes
LGTM 🚀

@andrew-goldstein
Copy link
Contributor

@elasticmachine merge upstream

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 3768aab into elastic:master Aug 24, 2020
@MadameSheema MadameSheema deleted the fixes-url-timeline-test branch August 24, 2020 12:41
@MadameSheema MadameSheema mentioned this pull request Aug 24, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 24, 2020
@MadameSheema @elasticmachine
[SIEM] Fixes 'sets and reads the url state for timeline by id' timeli…
6464f73 
…ne Cypress test (elastic#75125)

* fixes 'sets and reads the url state for timeline by id' timeline ttest

* makes test more reliable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MadameSheema added a commit that referenced this pull request Aug 24, 2020
@MadameSheema @elasticmachine
[SIEM] Fixes 'sets and reads the url state for timeline by id' timeli…
18277b7 
…ne Cypress test (#75125) (#75745)

* fixes 'sets and reads the url state for timeline by id' timeline ttest

* makes test more reliable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@stephmilovic stephmilovic Awaiting requested review from stephmilovic

@angorayc angorayc Awaiting requested review from angorayc

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @andrew-goldstein @kibanamachine @MindyRS