Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTML style guide. Specify that the opening tag's closing bracket goes on its own line. #7521

Merged
merged 1 commit into from
Jun 27, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions style_guides/html_style_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,26 @@

## Multiple attribute values

When a node has multiple attributes that would cause it to exceed the 80-character line limit, each attribute including the first should be on its own line with a single indent. Also, when a node that is styled in this way has child nodes, there should be a blank line between the opening parent tag and the first child tag.
When a node has multiple attributes, each attribute including the first should be on its own line with a single indent.

The closing bracket should be on its own line. This allows attributes to be shuffled and edited without having to move the bracket around. It also makes it easier to scan vertically and match opening and closing brackets.

```
<ul
<div
attribute1="value1"
attribute2="value2"
attribute3="value3">
attribute3="value3"
>
Hello
</div>
```

If the node doesn't have child notes, add the closing tag on the same line as the opening tag's closing bracket.

<li></li>
<li></li>
...
</ul>
```
<div
attribute1="value1"
attribute2="value2"
attribute3="value3"
></div>
```