Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix rollup related bugs #75314

Merged
merged 4 commits into from
Aug 26, 2020
Merged

[Lens] Fix rollup related bugs #75314

merged 4 commits into from
Aug 26, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Aug 18, 2020 •
edited
Loading

Fixes #74348

This PR fixes problems with the Lens rollup integration.

  • useNormalizedEsIntervals has to be set to false for rollup date fields - this PR passes the index pattern to the toEsAggsConfig function of the individual operations to pull out the information about restrictions there
  • The field existence endpoint doesn't work for rolled up fields. This PR avoids the request when there are restrictions and simply shows all fields in this case - I extended the local IndexPattern type with a hasRestrictions flag
  • This PR also adds some functional tests for rollups in Lens

@flash1293
Copy link
Contributor Author

Jenkins, test this.

@flash1293 flash1293 marked this pull request as ready for review August 19, 2020 12:50
@flash1293 flash1293 requested a review from a team August 19, 2020 12:50
@flash1293 flash1293 mentioned this pull request Aug 19, 2020
Closed
59 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lens 867.6KB +778.0B 866.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra requested review from wylieconlon and dej611 August 25, 2020 13:40
mbondyra
mbondyra approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes the bugs in the issue.
Code looks good to me.

@mbondyra mbondyra merged commit ddf99b6 into elastic:master Aug 26, 2020
mbondyra added a commit to mbondyra/kibana that referenced this pull request Aug 26, 2020
@flash1293 @mbondyra
[Lens] Fix rollup related bugs (elastic#75314)
b05339f 
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
@mbondyra mbondyra mentioned this pull request Aug 26, 2020
Merged
mbondyra added a commit that referenced this pull request Aug 26, 2020
@mbondyra @flash1293
[Lens] Fix rollup related bugs (#75314) (#75949)
0a1023c 
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
mshustov added a commit to mshustov/kibana that referenced this pull request Aug 26, 2020
@mshustov
Revert "[Lens] Fix rollup related bugs (elastic#75314)"
4301f68 
This reverts commit ddf99b6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@wylieconlon wylieconlon Awaiting requested review from wylieconlon

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
Feature:Lens release_note:fix v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Rollup indices don't work properly
3 participants
@flash1293 @kibanamachine @mbondyra