Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (#74953) #75409

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

… annotations. (elastic#74953)

Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer.
Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible.
Now a callout is shown when annotations fail to load.
@walterra walterra self-assigned this Aug 19, 2020
@walterra walterra added the :ml label Aug 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.0MB +6.8KB 8.0MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 381e037 into elastic:7.x Aug 19, 2020
@walterra walterra deleted the backport/7.x/pr-74953 branch August 19, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants