[Drilldowns] Beta badge support. Mark URL Drilldown as Beta #75654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
v8.0.0
Team:AppArch
release_note:skip
5 tasks
|
@elasticmachine merge upstream |
…into dev/drilldowns-beta-badge
…s-beta-badge # Conflicts: # x-pack/examples/ui_actions_enhanced_examples/public/dashboard_to_url_drilldown/index.tsx # x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/action_wizard.tsx # x-pack/plugins/ui_actions_enhanced/public/components/action_wizard/i18n.ts # x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_definition.ts # x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/action_factory_definition.ts
Dosant
changed the title
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
elastic-jb
approved these changes
Sep 17, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Sep 18, 2020
…75654) Team agreed that we'd like to release URL drilldown MVP as Beta. Reasons for it: 1. Caveats in current URL drilldown UX (dummy values in preview, too vague triggers, {{event.points}} hack). It might that improving those would require a breaking change in an API. We will do our best to handle changes with migrations, but there could be edge cases we won't be able to cover. 2. We decided not to rush with extending url templating capabilities with more helpers. We could find out from early feedback that essential helpers are required. Even though this won't be breaking, worth mentioning here. 3. Since URL drilldown is a new feature and relies on user's input, we might get early feedback that would required us for a significant changes in the feature. Make it Beta gives us more room for a pivot in this case. 4. API Action concept might change how we reason about URL drilldown Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant
added a commit
that referenced
this pull request
Sep 18, 2020
…77860) Team agreed that we'd like to release URL drilldown MVP as Beta. Reasons for it: 1. Caveats in current URL drilldown UX (dummy values in preview, too vague triggers, {{event.points}} hack). It might that improving those would require a breaking change in an API. We will do our best to handle changes with migrations, but there could be edge cases we won't be able to cover. 2. We decided not to rush with extending url templating capabilities with more helpers. We could find out from early feedback that essential helpers are required. Even though this won't be breaking, worth mentioning here. 3. Since URL drilldown is a new feature and relies on user's input, we might get early feedback that would required us for a significant changes in the feature. Make it Beta gives us more room for a pivot in this case. 4. API Action concept might change how we reason about URL drilldown Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (92 commits) [ILM] Data tiers for 7.10 (elastic#76126) [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789) [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654) Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746) [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598) [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688) fixed react warning in Suspense in alert flyout (elastic#77777) [APM] Track usage of Gold+ features (elastic#77630) Visualize: Bad request when working with histogram aggregation (elastic#77684) remove legacy ES plugin (elastic#77703) [Lens] change name of custom query to filters (elastic#77725) skip flaky suite (elastic#76239) remove visual aspects of baseline job (elastic#77815) skip flaky suite (elastic#77835) Fixes typo in data recognizer text (elastic#77691) management/update trusted_apps jest snapshot [build] Use Elastic hosted UBI minimal base image (elastic#77776) [APM] Add transaction error rate alert (elastic#76933) [Security Solution] [Detections] Remove file validation on import route (elastic#77770) [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of: #69409
Team agreed that we'd like to release URL drilldown MVP as Beta.
Reasons for it:
This pr adds support for
isBetaproperty on drilldown definition, which displays beta badge in action wizard. I took copy from other place (I think from Lens).This pr also marks URL drilldown as Beta.
I also updated URL drilldown docs to include default
Betawarning:Checklist
Delete any items that are not applicable to this PR.