-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolver fix of old tests #75675
Resolver fix of old tests #75675
Conversation
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each function you have added, please make sure that the name, comments, and behavior all match each other. Ideally readers should be able to read the name of a function and have some idea about it's behavior.
Also please remove the sleep
call and instead wait for the elements you interact with to be present before interacting with them. This will avoid unnecessary waits and it will allow the timeouts to be configured by test maintainers as needed. It will also make our tests more robust. We don't know how slow the CI might run our tests.
Please reduce the size of the test archive. Only include the data you need. Also please compress the archive.
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/page_objects/hosts_page.ts
Outdated
Show resolved
Hide resolved
Added delete DataStream function.
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned because this adds a large uncompressed json file. Can we talk about alteratives?
# Conflicts: # x-pack/test/security_solution_endpoint_api_int/apis/data_stream_helper.ts
# Conflicts: # x-pack/test/security_solution_endpoint_api_int/apis/data_stream_helper.ts
# Conflicts: # x-pack/test/security_solution_endpoint_api_int/apis/data_stream_helper.ts
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's been an issue when rebasing the branch from master
. It is undoing some of our changes we got merged this morning.
|
||
const pair = { key: metricType.join(':'), value: count }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reverting a fix we just merged this morning (#76913).
Maybe an issue when updating the branch from master
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not touch this file
💔 Build Failed
Failed CI StepsTest FailuresX-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list·ts.endpoint endpoint list when initially navigating to page finds data after load and pollingStandard Out
Stack Trace
X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list·ts.endpoint endpoint list when initially navigating to page finds data after load and pollingStandard Out
Stack Trace
Build metrics@kbn/optimizer bundle module count
async chunks size
miscellaneous assets size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
Summary
This Is the Fix for the Resolver tests that was removed
Checklist
Delete any items that are not applicable to this PR.
For maintainers