-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Add telemetry around workpad variable usage #75683
[Canvas] Add telemetry around workpad variable usage #75683
Conversation
Pinging @elastic/kibana-canvas (Team:Canvas) |
@elasticmachine merge upstream |
@poffdeluxe does this PR let us know which variable types are being used, such as string, etc? Do you think that would be valuable to have? I posit it would be nice to know this, so as to tailor our work for those variable types that are getting the most play in the next round, perhaps. |
We could add something in there to count the variable types. My only concern is whether or not knowing the type of variable without knowing the usage is super helpful. For example, maybe they have a bunch of boolean variables but we don't know the context -- are they using them to filter a query or are they just using them to hide labels on a chart |
@poffdeluxe I wholeheartedly that the context variables are being used in would be helpful. Is there that possibility here at the moment, or perhaps the next go around we could capture context. I think it's helpful to know who's using what without knowing specifically what they are using it for, and want to reiterate that point. Perhaps there is the option to get the context next if not possible right now. What do you think? |
I think it's a good idea but I vote let's punt on it. I think it'd be interesting to report in telemetry the top functions that the var function is being used in and that'd give us a pretty good idea how its used. This could dovetail nicely with follow-on variables work I want to do around detecting where a variable is being used on a workpad to let users know what might change if they change the variable so maybe we can add this at that point |
…bana into telemetry/canvas-variables
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
* Add telemetry around workpad variable usage * Fix typecheck Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Adds variable counts (total, min, max, average in workpads) to workpad usage telemetry
Addresses one of the todo items in #75604
Checklist