Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Add telemetry around workpad variable usage #75683

Merged
merged 6 commits into from
Aug 31, 2020

Conversation

poffdeluxe
Copy link
Contributor

@poffdeluxe poffdeluxe commented Aug 21, 2020

Summary

Adds variable counts (total, min, max, average in workpads) to workpad usage telemetry

Addresses one of the todo items in #75604

Checklist

@poffdeluxe poffdeluxe added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.10.0 labels Aug 21, 2020
@poffdeluxe poffdeluxe requested a review from a team as a code owner August 21, 2020 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe poffdeluxe added the release_note:skip Skip the PR/issue when compiling release notes label Aug 21, 2020
@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@shaunmcgough
Copy link

@poffdeluxe does this PR let us know which variable types are being used, such as string, etc? Do you think that would be valuable to have? I posit it would be nice to know this, so as to tailor our work for those variable types that are getting the most play in the next round, perhaps.

@poffdeluxe
Copy link
Contributor Author

@poffdeluxe does this PR let us know which variable types are being used, such as string, etc? Do you think that would be valuable to have? I posit it would be nice to know this, so as to tailor our work for those variable types that are getting the most play in the next round, perhaps.

We could add something in there to count the variable types. My only concern is whether or not knowing the type of variable without knowing the usage is super helpful. For example, maybe they have a bunch of boolean variables but we don't know the context -- are they using them to filter a query or are they just using them to hide labels on a chart

@shaunmcgough
Copy link

@poffdeluxe I wholeheartedly that the context variables are being used in would be helpful. Is there that possibility here at the moment, or perhaps the next go around we could capture context. I think it's helpful to know who's using what without knowing specifically what they are using it for, and want to reiterate that point. Perhaps there is the option to get the context next if not possible right now. What do you think?

@poffdeluxe
Copy link
Contributor Author

@poffdeluxe I wholeheartedly that the context variables are being used in would be helpful. Is there that possibility here at the moment, or perhaps the next go around we could capture context. I think it's helpful to know who's using what without knowing specifically what they are using it for, and want to reiterate that point. Perhaps there is the option to get the context next if not possible right now. What do you think?

I think it's a good idea but I vote let's punt on it. I think it'd be interesting to report in telemetry the top functions that the var function is being used in and that'd give us a pretty good idea how its used. This could dovetail nicely with follow-on variables work I want to do around detecting where a variable is being used on a workpad to let users know what might change if they change the variable so maybe we can add this at that point

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 7b807b7 into elastic:master Aug 31, 2020
@poffdeluxe poffdeluxe deleted the telemetry/canvas-variables branch August 31, 2020 21:54
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request Aug 31, 2020
* Add telemetry around workpad variable usage

* Fix typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
poffdeluxe added a commit that referenced this pull request Sep 1, 2020
* Add telemetry around workpad variable usage

* Fix typecheck

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants