Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Originating App Breadcrumb #75692

Merged
merged 5 commits into from
Aug 25, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 21, 2020

#75470 added originating application to breadcrumbs for lens. Maps app should do the same to provide a consistent user experience.

When using save and return flow from dashboard or canvas, the originating application name will now appear in the breadcrumbs

Screen Shot 2020-08-21 at 12 12 42 PM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.10.0 labels Aug 21, 2020
@nreese nreese requested a review from thomasneirynck August 21, 2020 18:30
@nreese nreese requested a review from a team as a code owner August 21, 2020 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Aug 21, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 21, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Aug 24, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
maps 695 +1 694

async chunks size

id value diff baseline
maps 3.3MB +664.0B 3.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch 🎆

@nreese nreese merged commit c3e226c into elastic:master Aug 25, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 25, 2020
* [Maps] Originating App Breadcrumb

* pass getHasUnsavedChanges instead of passing boolean

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Aug 25, 2020
* [Maps] Originating App Breadcrumb

* pass getHasUnsavedChanges instead of passing boolean

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants