[Resolver] restore function to the resolverTest plugin. #75799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatkiller
added
Feature:Resolver
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
oatkiller
force-pushed
the
resolver-test-plugin-3
branch
from
fa81aae to
0ca65b3
Compare
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
| }, | ||
| } = resolverPluginSetup; | ||
| const dataAccessLayer: DataAccessLayer = useMemo( | ||
| () => noAncestorsTwoChildren().dataAccessLayer, |
There was a problem hiding this comment.
Just out of curiosity, how would you see us expanding this to support multiple dataAccessLayers. Some kind of flag or config?
There was a problem hiding this comment.
great question +1
michaelolo24
approved these changes
Aug 25, 2020
XavierM
reviewed
Aug 25, 2020
| @@ -319,7 +319,12 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S | |||
| }, | |||
| }); | |||
|
|
|||
| return {}; | |||
| return { | |||
| resolver: async () => { | |||
There was a problem hiding this comment.
<3 that's awesome to see!!! <3
XavierM
reviewed
Aug 25, 2020
| Provider, | ||
| storeFactory: resolverStoreFactory, | ||
| ResolverWithoutProviders, | ||
| mocks: { |
There was a problem hiding this comment.
that's an interesting way of mocking the data, would like to know more about your technique here
XavierM
approved these changes
Aug 25, 2020
oatkiller
pushed a commit
to oatkiller/kibana
that referenced
this pull request
Aug 25, 2020
Restore the resolverTest plugin. This will allow us to run the test plugin and try out Resolver using our mock data access layers. Eventually this could be expanded to support multiple different data access layers. It could even be expanded to allow us to control the data access layer via the browser. Another option: we could export the APIs from the server and use those in this test plugin. We eventually expect other plugins to use Resolver. This test plugin could allow us to test Resolver via the FTR (separately of the Security Solution.) This would also be useful for writing tests than use the FTR but which are essentially unit tests. For example: taking screenshots, using the mouse to zoom/pan. Start using: `yarn start --plugin-path x-pack/test/plugin_functional/plugins/resolver_test/`
oatkiller
pushed a commit
that referenced
this pull request
Aug 25, 2020
) Restore the resolverTest plugin. This will allow us to run the test plugin and try out Resolver using our mock data access layers. Eventually this could be expanded to support multiple different data access layers. It could even be expanded to allow us to control the data access layer via the browser. Another option: we could export the APIs from the server and use those in this test plugin. We eventually expect other plugins to use Resolver. This test plugin could allow us to test Resolver via the FTR (separately of the Security Solution.) This would also be useful for writing tests than use the FTR but which are essentially unit tests. For example: taking screenshots, using the mouse to zoom/pan. Start using: `yarn start --plugin-path x-pack/test/plugin_functional/plugins/resolver_test/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restore the resolverTest plugin. This will allow us to run the test plugin and try out Resolver using our mock data access layers. Eventually this could be expanded to support multiple different data access layers. It could even be expanded to allow us to control the data access layer via the browser. Another option: we could export the APIs from the server and use those in this test plugin.
We eventually expect other plugins to use Resolver. This test plugin could allow us to test Resolver via the FTR (separately of the Security Solution.)
This would also be useful for writing tests than use the FTR but which are essentially unit tests. For example: taking screenshots, using the mouse to zoom/pan.
Start using:
yarn start --plugin-path x-pack/test/plugin_functional/plugins/resolver_test/Screenshot (from commit d6c62b2)
