Compute AAD to encrypty/decrypt SO only if needed #75818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
release_note:skip
nchaulet
force-pushed
the
feature-lazy-add-encryption
branch
from
022b17f to
e189d1c
Compare
nchaulet
changed the title
nchaulet
force-pushed
the
feature-lazy-add-encryption
branch
from
e189d1c to
1674914
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kobelb
reviewed
Aug 25, 2020
kobelb
approved these changes
Aug 26, 2020
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Aug 26, 2020
nchaulet
added a commit
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on optimizing Fleet performance I noticed we compute the AAD for encrypting saved object even if we do not encrypt any attribute.
In Fleet this mean a lot of AAD get can computed for nothing, for example we are doing a periodical call to do a bulk update on every agent to set a timestamp
last_checkina field that is not encrypted.I think we can avoid that call when not needed.
TODO
This change seems to have a limited impact on fleet performance, but it still thinks looks like a small improvment