Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix dimension popover design on mobile #75866

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[Lens] fix dimension popover design on mobile #75866

merged 1 commit into from
Aug 25, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Aug 25, 2020 •
edited
Loading

Summary

Fixes #75855
Fixes mobile view of dimension popover:
Before:
image
After:
image

@mbondyra mbondyra added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.10.0 labels Aug 25, 2020
@mbondyra mbondyra requested a review from a team August 25, 2020 11:49
@mbondyra mbondyra requested a review from a team as a code owner August 25, 2020 11:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

dej611
dej611 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .
I noticed other styling issues on mobile while testing this: will open other issues about them.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lens 866.4KB +97.0B 866.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra requested a review from cchaos August 25, 2020 13:41
cchaos
cchaos approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for catching and updating this!

@mbondyra mbondyra merged commit 1fee8f1 into elastic:master Aug 25, 2020
@mbondyra mbondyra deleted the lens/mobile-dimension-popover branch August 26, 2020 06:58
@mbondyra mbondyra mentioned this pull request Aug 26, 2020
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request Aug 26, 2020
@mbondyra
[Lens] fix dimension popover design on mobile (elastic#75866)
7f0f36a
mbondyra added a commit that referenced this pull request Aug 26, 2020
@mbondyra
[Lens] fix dimension popover design on mobile (#75866) (#75947)
c40d295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Dimension popovers on mobile don't look good
5 participants
@mbondyra @elasticmachine @kibanamachine @cchaos @dej611