Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy map UI settings #75887

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 25, 2020

Fixes #74562

Migrates ui settings
visualization:tileMap:maxPrecision 👉maps_legacy
visualization:tileMap:WMSdefaults 👉maps_legacy
visualization:regionmap:showWarnings 👉region_map

TS checks required adding schema's for each ui setting. For visualization:tileMap:WMSdefaults, undefined where changed to empty strings.

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 25, 2020
@nreese nreese requested a review from thomasneirynck August 25, 2020 15:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch 🎆

@thomasneirynck thomasneirynck self-requested a review August 25, 2020 20:05
@nreese nreese merged commit f2fef70 into elastic:master Aug 25, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 25, 2020
* Migrate legacy map UI settings

* i18n fixes
nreese added a commit that referenced this pull request Aug 25, 2020
* Migrate legacy map UI settings

* i18n fixes
@thomasneirynck
Copy link
Contributor

fwiw, I believe this fixed a bug where visualization:regionmap:showWarnings was ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate legacy map UI settings
4 participants