Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding authorization header to DFA job update request #75899

Merged
merged 1 commit into from
Aug 26, 2020
Merged

[ML] Adding authorization header to DFA job update request #75899

merged 1 commit into from
Aug 26, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 25, 2020 •
edited
Loading

Authorization headers should be sent as part of the DFA update request.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic self-assigned this Aug 26, 2020
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features v7.10.0 v7.9.1 v8.0.0 review labels Aug 26, 2020
@jgowdyelastic jgowdyelastic marked this pull request as ready for review August 26, 2020 16:12
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 26, 2020 16:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out editing and then starting a DFA job. LGTM.

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 61550b7 into elastic:master Aug 26, 2020
@jgowdyelastic jgowdyelastic deleted the adding-auth-headers-to-dfa-job-update branch August 26, 2020 19:08
@jgowdyelastic jgowdyelastic mentioned this pull request Aug 26, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 26, 2020
@jgowdyelastic
[ML] Adding authorization header to DFA job update request (elastic#7…
4e8c026 
…5899)
@jgowdyelastic jgowdyelastic mentioned this pull request Aug 26, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 26, 2020
@jgowdyelastic
[ML] Adding authorization header to DFA job update request (elastic#7…
d67e6d3 
…5899)

# Conflicts:
#	x-pack/plugins/ml/server/routes/data_frame_analytics.ts
jgowdyelastic added a commit that referenced this pull request Aug 27, 2020
@jgowdyelastic
[ML] Adding authorization header to DFA job update request (#75899) (#…
4c44031 
…76019)
jgowdyelastic added a commit that referenced this pull request Aug 27, 2020
@jgowdyelastic
[ML] Adding authorization header to DFA job update request (#75899) (#…
802ef8e 
…76020)

# Conflicts:
#	x-pack/plugins/ml/server/routes/data_frame_analytics.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix review v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @kibanamachine @elasticmachine @alvarezmelissa87 @peteharverson