Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate title warning wording #75908

Merged
merged 10 commits into from
Aug 26, 2020
Merged

Duplicate title warning wording #75908

merged 10 commits into from
Aug 26, 2020

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Aug 25, 2020 •
edited
Loading

Summary

Closes #75665

Implements a small wording change for the duplicate save object title warning.

Screen Shot 2020-08-25 at 2 00 48 PM

@gchaps it's important to note that this changes the wording for most saved object types:

Screen Shot 2020-08-25 at 2 00 15 PM

Screen Shot 2020-08-25 at 2 01 34 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 25, 2020
@ThomThomson ThomThomson requested a review from a team August 25, 2020 17:43
@ThomThomson ThomThomson requested a review from a team as a code owner August 25, 2020 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Aug 25, 2020
gchaps
gchaps approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM

@ThomThomson ThomThomson force-pushed the duplicateTitleWording branch from 50fe6ab to 36e1b54 Compare August 26, 2020 15:30
dej611
dej611 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
savedObjects 237.0KB -357.0B 237.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit fd39f09 into elastic:master Aug 26, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 26, 2020
@ThomThomson
Duplicate title warning wording (elastic#75908)
7ae7b4a 
Changed wording on duplicate title warning.
@ThomThomson ThomThomson mentioned this pull request Aug 26, 2020
Merged
ThomThomson added a commit that referenced this pull request Aug 26, 2020
@ThomThomson
Duplicate title warning wording (#75908) (#76037)
969eaef 
Changed wording on duplicate title warning.
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 8, 2020
@ThomThomson
fixed typo from elastic#75908
4df8cdb
@ThomThomson ThomThomson mentioned this pull request Sep 8, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@dej611 dej611 dej611 approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit text in Save book modal
6 participants
@ThomThomson @elasticmachine @kibanamachine @mattkime @dej611 @gchaps