Remove angular-bootstrap dependency. #7591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
refactor/remove-angular-bootstrap-dependency
branch
2 times, most recently
from
6ffe248 to
4a552b8
Compare
|
Assuming tests pass, LGTM |
|
jenkins, test it |
|
What are your thoughts on getting the |
|
Shoot, you're right. Editing the templates will especially be a PITA. I'll replace the compiled file with the source and original html templates. |
|
@tylersmalley I just incorporated your suggestion. Could you take a look? Turns out the eslintignore file isn't used by our eslint task: #7622 |
…ublic/angular-bootstrap directory for future refactoring and deprecation.
cjcenizal
force-pushed
the
refactor/remove-angular-bootstrap-dependency
branch
from
83c2b4f to
b08f016
Compare
|
This is much more maintainable - thanks for the update. LGTM |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…r-bootstrap-dependency Remove angular-bootstrap dependency. Former-commit-id: f23d98e
cee-chen
added a commit
that referenced
this pull request
Mar 26, 2024
`v93.4.0` ⏩ `v93.5.1` --- ## [`v93.5.1`](https://github.com/elastic/eui/releases/v93.5.1) **Bug fixes** - Fixed unvirtualized `EuiSelectable`s to not cause Jest/jsdom errors on active option change ([#7618](elastic/eui#7618)) ## [`v93.5.0`](https://github.com/elastic/eui/releases/v93.5.0) - `EuiHeaderLinks` now accepts a `children` render function that will be passed a `closeMobilePopover` callback, allowing consumers to close the mobile popover by its content ([#7603](elastic/eui#7603)) - Updated `EuiSelectable` to support scrolling list containers when `listProps.isVirtualization` is set to `false` ([#7609](elastic/eui#7609)) **Bug fixes** - Fixed `EuiIconTip`'s default `aria-label` text to be i18n tokenizable ([#7606](elastic/eui#7606)) - Fixed `EuiTextArea`'s CSS box model to no longer render a few extra pixels of strut height ([#7607](elastic/eui#7607)) **Dependency updates** - Updated `@types/refractor` to v3.4.0 ([#7590](elastic/eui#7590)) - Updated `@types/lodash` to v4.14.202 ([#7591](elastic/eui#7591)) - Removed `@types/resize-observer-browser` dependency. `ResizeObserver` types should already be baked in to Typescript as of 4.2+ ([#7592](elastic/eui#7592)) - Updated `classnames` to v2.5.1 ([#7593](elastic/eui#7593)) - Updated `@types/numeral` to v2.0.5 ([#7594](elastic/eui#7594)) - Updated `@types/react-window` to 1.8.8 ([#7597](elastic/eui#7597)) - Updated `prop-types` to v15.18.1 ([#7602](elastic/eui#7602)) - Removed `prop-types` as a peer dependency, per package recommendation ([#7602](elastic/eui#7602)) **Accessibility** - `EuiIcons` no longer apply `aria-hidden` to empty icons, as long as a valid title or label is provided to the icon. In particular, this is intended to improve the accessibility of loading `EuiIconTip`s. ([#7606](elastic/eui#7606))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy required code into
src/ui/public/angular-bootstrapdirectory for future refactoring and deprecation.Goals
Our UI components should have a coherent interface with consistent rules and patterns of use. The first step is to gain control over 100% of the components we use in our UI. This means migrating off Bootstrap and third-party UI frameworks like Angular-UI.