Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test user to maps es_pew_pew_source #75920

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Adding test user to maps es_pew_pew_source #75920

merged 1 commit into from
Aug 26, 2020

Conversation

bhavyarm
Copy link
Contributor

Meta issue: #60815

Added test user to pew pew maps test and along with a role to read connections index data to config

@bhavyarm bhavyarm self-assigned this Aug 25, 2020
@bhavyarm bhavyarm added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:QA Team label for QA Team test_xpack_functional labels Aug 25, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as ready for review August 25, 2020 22:21
@bhavyarm bhavyarm requested a review from a team as a code owner August 25, 2020 22:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

LeeDr
LeeDr approved these changes Aug 26, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I only code reviewed.

thomasneirynck
thomasneirynck approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, code review

@bhavyarm bhavyarm merged commit 4f2d4f8 into elastic:master Aug 26, 2020
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Aug 26, 2020
@bhavyarm
adding test user to pew pew maps test + adding a role for connections…
16794e6 
… index pattern (elastic#75920)
@bhavyarm bhavyarm mentioned this pull request Aug 26, 2020
Merged
bhavyarm added a commit that referenced this pull request Aug 27, 2020
@bhavyarm
adding test user to pew pew maps test + adding a role for connections…
334431e 
… index pattern (#75920) (#75982)
@bhavyarm bhavyarm mentioned this pull request Feb 5, 2021
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees

@bhavyarm bhavyarm

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_xpack_functional v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibanamachine @elasticmachine @thomasneirynck @LeeDr