Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove "Are you sure" from anomaly detection jobs #75931

Merged
merged 4 commits into from
Sep 1, 2020
Merged

[ML] Remove "Are you sure" from anomaly detection jobs #75931

merged 4 commits into from
Sep 1, 2020

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 25, 2020 •
edited
Loading

Summary

Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some machine learning occurrences of that text.

Checklist

Delete any items that are not applicable to this PR.

Screenshots (Before)

Delete anomaly detection job:

image

Delete multiple anomaly detection jobs:

image

Delete rule:

image (3)

Screenshots (After)

Delete single job:

image

Delete multiple jobs:

image

Delete rule:

image (4)

@lcawl lcawl added the Feature:Anomaly Detection ML anomaly detection label Aug 28, 2020
@lcawl lcawl changed the title [ML] Avoid using "Are you sure" [ML] Remove "Are you sure" from anomaly detection jobs Aug 31, 2020
@lcawl lcawl marked this pull request as ready for review August 31, 2020 17:01
@lcawl lcawl requested a review from a team as a code owner August 31, 2020 17:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Aug 31, 2020
@lcawl
Copy link
Contributor Author

lcawl commented Aug 31, 2020

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@lcawl lcawl merged commit 9a27beb into elastic:master Sep 1, 2020
@lcawl lcawl deleted the ml-text branch September 1, 2020 14:11
@lcawl lcawl removed the v7.11.0 label Sep 1, 2020
@lcawl lcawl mentioned this pull request Sep 1, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Sep 1, 2020
@lcawl
[ML] Remove "Are you sure" from anomaly detection jobs (elastic#75931)
9072c11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB -1.7KB 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lcawl added a commit that referenced this pull request Sep 1, 2020
@lcawl
[ML] Remove "Are you sure" from anomaly detection jobs (#75931) (#76390)
3260536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @elasticmachine @kibanamachine @peteharverson