Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove encoding for scheduled events labels #75973

Merged
merged 4 commits into from
Aug 27, 2020
Merged

[ML] Remove encoding for scheduled events labels #75973

merged 4 commits into from
Aug 27, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Fixes #74938

HTML encoding is not needed for tooltip content. For some reason, it was applied for Anomaly explorer charts. Since we updated mlEscape function to utilize he encoding lib with enabled encodeEverything option, space symbols also got replaced with HTML character reference &x20;.

image

@darnautov darnautov requested a review from a team as a code owner August 26, 2020 12:50
@darnautov darnautov self-assigned this Aug 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a job on the special_characters data set and LGTM

image

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB +382.0B 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit e488c08 into elastic:master Aug 27, 2020
This was referenced Aug 27, 2020
Merged
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Aug 27, 2020
@darnautov @elasticmachine
[ML] fix tooltip content for scheduled events (elastic#75973)
d79e327 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
darnautov added a commit to darnautov/kibana that referenced this pull request Aug 27, 2020
@darnautov @elasticmachine
[ML] fix tooltip content for scheduled events (elastic#75973)
cd7661c 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
darnautov added a commit that referenced this pull request Aug 27, 2020
@darnautov
[ML] fix tooltip content for scheduled events (#75973) (#76067)
3512f57
darnautov added a commit that referenced this pull request Aug 27, 2020
@darnautov @elasticmachine
[ML] fix tooltip content for scheduled events (#75973) (#76066)
863aaf3 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly explorer - spaces in event name are not displayed correctly in tooltip
4 participants
@darnautov @elasticmachine @kibanamachine @peteharverson