[Reporting] Add functional test for Reports in non-default spaces #76053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
fix/72875
branch
2 times, most recently
from
e4d7969 to
5f35de7
Compare
tsullivan
added
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tsullivan
commented
Aug 31, 2020
| @@ -21,7 +21,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
| const reportingAPI = getService('reportingAPI'); | |||
| const usageAPI = getService('usageAPI'); | |||
|
|
|||
| describe('reporting usage', () => { | |||
| describe('Usage', () => { | |||
There was a problem hiding this comment.
The full name of the test was Reporting reporting Usage and this changes it to Reporting Usage
tsullivan
commented
Aug 31, 2020
| @@ -20,7 +20,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
| * The Reporting API Functional Test config implements a network policy that | |||
| * is designed to disallow the following Canvas worksheet | |||
| */ | |||
| describe('reporting network policy', () => { | |||
| describe('Network Policy', () => { | |||
There was a problem hiding this comment.
Because of an external describe that wrap an import of this file, the name of the test was Reporting reporting Network Policy and removes the repetition
|
This was acting flaky in my local environment last week, but it seems better this week(?) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
joelgriffith
approved these changes
Sep 1, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Sep 2, 2020
…astic#76053) * [Reporting] Add functional test for Download CSV in non-default space * skip tests * unskip * rm comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 2, 2020
* master: (223 commits) skip flaky suite (elastic#75724) [Reporting] Add functional test for Reports in non-default spaces (elastic#76053) [Enterprise Search] Fix various icons in dark mode (elastic#76430) skip flaky suite (elastic#76245) Add `auto` interval to histogram AggConfig (elastic#76001) [Resolver] generator uses setup_node_env (elastic#76422) [Ingest Manager] Support both zip & tar archives from Registry (elastic#76197) [Ingest Manager] Improve agent vs kibana version checks (elastic#76238) Manually building `KueryNode` for Fleet's routes (elastic#75693) remove dupe tinymath section (elastic#76093) Create APM issue template (elastic#76362) Delete unused file. (elastic#76386) [SECURITY_SOLUTION][ENDPOINT] Trusted Apps Create API (elastic#76178) [Detections Engine] Add Alert actions to the Timeline (elastic#73228) [Dashboard First] Library Notification (elastic#76122) [Maps] Add mvt support for ES doc sources (elastic#75698) Add setHeaderActionMenu API to AppMountParameters (elastic#75422) [ML] Remove "Are you sure" from data frame analytics jobs (elastic#76214) [yarn] remove typings-tester, use @ts-expect-error (elastic#76341) [Reporting/CSV] Do not fail the job if scroll ID can not be cleared (elastic#76014) ...
myasonik
pushed a commit
to myasonik/kibana
that referenced
this pull request
Sep 2, 2020
…astic#76053) * [Reporting] Add functional test for Download CSV in non-default space * skip tests * unskip * rm comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2 tasks
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #72875
This PR adds an API integration test to ensure that if saved objects are within a non-default space, exporting via the job generation API will still work.