Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): add elastic prefix to eslint-config-kibana #76059

Merged
merged 4 commits into from
Aug 31, 2020
Merged

chore(NA): add elastic prefix to eslint-config-kibana #76059

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89390d3
chore(NA): add elastic prefix to eslint-config-kibana
mistic Aug 27, 2020
72309c6
Merge remote-tracking branch 'upstream/master' into elastic-prefix-fo…
mistic Aug 27, 2020
5b99fd0
Merge branch 'master' into elastic-prefix-for-eslint-config-kibana
elasticmachine Aug 27, 2020
8ea1dec
Merge branch 'master' into elastic-prefix-for-eslint-config-kibana
elasticmachine Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ target
/x-pack/legacy/plugins/maps/public/vendor/**

# package overrides
/packages/eslint-config-kibana
/packages/elastic-eslint-config-kibana
/packages/kbn-interpreter/src/common/lib/grammar.js
/packages/kbn-plugin-generator/template
/packages/kbn-pm/dist
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/getting-started/running-kibana-advanced.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ If you’re installing dependencies and seeing an error that looks
something like

....
Unsupported URL Type: link:packages/eslint-config-kibana
Unsupported URL Type: link:packages/elastic-eslint-config-kibana
....

you’re likely running `npm`. To install dependencies in {kib} you
Expand Down
0 packages/eslint-config-kibana/.eslintrc.js → ...elastic-eslint-config-kibana/.eslintrc.js
View file
Open in desktop
File renamed without changes.
0 packages/eslint-config-kibana/.gitignore → ...s/elastic-eslint-config-kibana/.gitignore
View file
Open in desktop
File renamed without changes.
0 packages/eslint-config-kibana/.npmignore → ...s/elastic-eslint-config-kibana/.npmignore
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/eslint-config-kibana/README.md → ...es/elastic-eslint-config-kibana/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# eslint-config-kibana
# elastic-eslint-config-kibana

The eslint config used by the kibana team

Expand Down
0 packages/eslint-config-kibana/javascript.js → ...lastic-eslint-config-kibana/javascript.js
View file
Open in desktop
File renamed without changes.
0 packages/eslint-config-kibana/jest.js → ...ages/elastic-eslint-config-kibana/jest.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions packages/eslint-config-kibana/package.json → ...elastic-eslint-config-kibana/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
"main": ".eslintrc.js",
"repository": {
"type": "git",
"url": "git+https://github.com/elastic/eslint-config-kibana.git"
"url": "git+https://github.com/elastic/kibana.git"
},
"keywords": [],
"author": "Spencer Alger <email@spalger.com>",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/elastic/kibana/tree/master/packages/eslint-config-kibana"
"url": "https://github.com/elastic/kibana/tree/master/packages/elastic-eslint-config-kibana"
},
"homepage": "https://github.com/elastic/kibana/tree/master/packages/eslint-config-kibana",
"homepage": "https://github.com/elastic/kibana/tree/master/packages/elastic-eslint-config-kibana",
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^3.10.0",
"@typescript-eslint/parser": "^3.10.0",
Expand Down
0 packages/eslint-config-kibana/react.js → ...ges/elastic-eslint-config-kibana/react.js
View file
Open in desktop
File renamed without changes.
0 ...slint-config-kibana/restricted_globals.js → ...slint-config-kibana/restricted_globals.js
View file
Open in desktop
File renamed without changes.
0 packages/eslint-config-kibana/typescript.js → ...lastic-eslint-config-kibana/typescript.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/kbn-pm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ From a plugin perspective there are two different types of Kibana dependencies:
runtime and static dependencies. Runtime dependencies are things that are
instantiated at runtime and that are injected into the plugin, for example
config and elasticsearch clients. Static dependencies are those dependencies
that we want to `import`. `eslint-config-kibana` is one example of this, and
that we want to `import`. `elastic-eslint-config-kibana` is one example of this, and
it's actually needed because eslint requires it to be a separate package. But we
also have dependencies like `datemath`, `flot`, `eui` and others that we
control, but where we want to `import` them in plugins instead of injecting them
Expand Down