-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[uiActions] notify action usage #76294
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
Notify feature usage when dynamic actions with specified license requirements are executed Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Notify feature usage when dynamic actions with specified license requirements are executed Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
closes #72019
Notify feature usage, when dynamic actions with specified license requirements is executed:
notifyFeature
is called insideaction.execute
. For example, in case of drill-downs,nofifyFeature
is called when end user drilling down into that chart.notifyUsage
is not called when dynamic action (or drill down) is created. (I think this is fine, most likely user who createsa drill down will go and test it end-to-end from a chart anyways and that is when
notifyUsage
is going to be called.getHref
: When drilldown popup is opened and then user used an action withright click + open in a new tab
, thenaction.execute()
andnotifyUsage
is not called. I think this is fine, as it shouldn't me a common use case comparing to regular click.There is a known issue when registering samefeatureName
more then once: Licensing: allow multiple registration of the same feature #76272licence
->license
, it was inconsistent: https://www.grammarly.com/blog/licence-license/Checklist
Delete any items that are not applicable to this PR.