Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Add cacheClear & cacheDelete methods #76306

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Aug 31, 2020

Summary

There are currently no cache invalidation/reduction methods for the EPM asset/archive cache. Add cacheDelete to remove one items and cacheClear to remove all.

We haven't needed them until now but cacheDelete would be useful for #68890

cacheClear doesn't have an explicit PR/issue afaik but I thought it'd be nice to have the ability to clear/purge without a Kibana restart

@jfsiii jfsiii requested a review from a team August 31, 2020 16:33
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii self-assigned this Aug 31, 2020
@jfsiii jfsiii added the release_note:skip Skip the PR/issue when compiling release notes label Aug 31, 2020
@nchaulet
Copy link
Member

@jfsiii How this is going to work on a multiple instance Kibana setup?

@jfsiii
Copy link
Contributor Author

jfsiii commented Aug 31, 2020

@nchaulet It's got the same flaws as the current approach does for get, set, etc. This just adds two more functions to remove item(s) from that cache

As I said, I see cacheDelete being used in a service as part of #68890

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit de9b7a4 into elastic:master Aug 31, 2020
jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Sep 2, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants