-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Anomaly Detection setup flow for Metrics #76787
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
- Remove server/lib/snapshot - Replace backend for /api/infra/snapshot with data from Metrics API - Fixing tests with updates to the snapshot node Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace all the npStart.http.fetch
requests with useHTTPRequest
hook (under public/hooks
). There seems to be a lot of duplicate functionality and it will make it easier update later.
@simianhacker switching to |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with a RO user and Admin and everything works as expected. Good Job!
███▄▄▄▄ ▄████████ ▄█ ▄█ ▄████████ ████████▄ ▄█ ███
███▀▀▀██▄ ███ ███ ███ ███ ███ ███ ███ ▀███ ███ ▀█████████▄
███ ███ ███ ███ ███▌ ███ ███ █▀ ███ ███ ███▌ ▀███▀▀██
███ ███ ███ ███ ███▌ ███ ▄███▄▄▄ ███ ███ ███▌ ███ ▀
███ ███ ▀███████████ ███▌ ███ ▀▀███▀▀▀ ███ ███ ███▌ ███
███ ███ ███ ███ ███ ███ ███ █▄ ███ ███ ███ ███
███ ███ ███ ███ ███ ███▌ ▄ ███ ███ ███ ▄███ ███ ███
▀█ █▀ ███ █▀ █▀ █████▄▄██ ██████████ ████████▀ █▀ ▄████▀
▀
▄█ ▄██████▄ ███ ▄▄▄▄███▄▄▄▄
███ ███ ███ ▀█████████▄ ▄██▀▀▀███▀▀▀██▄
███ ███ █▀ ▀███▀▀██ ███ ███ ███
███ ▄███ ███ ▀ ███ ███ ███
███ ▀▀███ ████▄ ███ ███ ███ ███
███ ███ ███ ███ ███ ███ ███
███▌ ▄ ███ ███ ███ ███ ███ ███
█████▄▄██ ████████▀ ▄████▀ ▀█ ███ █▀
▀
* adds metrics ml integration * Add ability to create ml jobs from inventory * Fix i18n stuff * Fix typecheck * renames jobs, updates datafeeds * adds allow_no_indices: true for datafeeds * Revert "[Metrics UI] Replace Snapshot API with Metrics API (elastic#76253)" This reverts commit 0ca6472. * Add ability to fetch anomalies * Fix typecheck * Fix typecheck * Fix i18n * Fix lint, use the right partition field * Delete log files * Fix merge * Fix merge issues * Update name of jobs * Remove CPU job * [Metrics UI] Replace Snapshot API with Metrics API (elastic#76253) - Remove server/lib/snapshot - Replace backend for /api/infra/snapshot with data from Metrics API - Fixing tests with updates to the snapshot node Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Add links back to ML for anomalies and manage jobs * Fix typecheck * Remove unecessary validation Co-authored-by: Michael Hirsch <michaelahirsch@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Chris Cowan <chris@chriscowan.us>
* adds metrics ml integration * Add ability to create ml jobs from inventory * Fix i18n stuff * Fix typecheck * renames jobs, updates datafeeds * adds allow_no_indices: true for datafeeds * Revert "[Metrics UI] Replace Snapshot API with Metrics API (#76253)" This reverts commit 0ca6472. * Add ability to fetch anomalies * Fix typecheck * Fix typecheck * Fix i18n * Fix lint, use the right partition field * Delete log files * Fix merge * Fix merge issues * Update name of jobs * Remove CPU job * [Metrics UI] Replace Snapshot API with Metrics API (#76253) - Remove server/lib/snapshot - Replace backend for /api/infra/snapshot with data from Metrics API - Fixing tests with updates to the snapshot node Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Add links back to ML for anomalies and manage jobs * Fix typecheck * Remove unecessary validation Co-authored-by: Michael Hirsch <michaelahirsch@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Chris Cowan <chris@chriscowan.us> Co-authored-by: Michael Hirsch <michaelahirsch@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Chris Cowan <chris@chriscowan.us>
Summary
Adds the ability to set up hosts and k8s anomaly detection jobs on the inventory screen, and adds endpoints and hooks for fetching anomalies associated with those jobs. The PR sets up an infra_ml directory that could become a shared directory with logs code in the future. There is a good amount of copying from logs taking place, and it would be good at some future date to refactor/dedupe some things. Fixes: #74808, #74807
Known issues
metrics-*
from your index pattern to make this work. This should be fixed by [ML] Datafeed fails on missing indices, even with allow_no_indices set to true elasticsearch#62404.Checklist
Delete any items that are not applicable to this PR.