Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Client side session service #76889
[Search] Client side session service #76889
Changes from 87 commits
1396af4
7bc93c3
e6f31d8
7de920f
b6eac29
9615706
812015d
739dde9
a9dec42
63c04d3
fc6d3c2
154a146
12e7898
f1390e2
1f9c340
e6a794d
13be80c
3e9dc9b
6f0b080
4f73686
021d12f
3035450
dd48dd2
21b44b7
aaa08cc
5a8dee8
8e09b74
396578d
f6fbb08
551335d
9b0e7ca
57b2a74
848eb0c
4e6f47d
741e8cd
40c9411
2c3d594
1142434
af29d63
a7fcea4
9c6972b
a9a1715
ecd5cce
8abced8
0f956c0
eed53fb
9b13bf9
990aba6
36400f0
8a25855
7b432ea
2c8e9ea
fc33904
dd7da3f
862d53a
db7ea0e
cd2bc82
b4034c2
3c0331f
b7e441d
92de71d
b07a802
b5beec7
2c503b8
26e8539
abffc40
6ce7fa9
8ae20f7
936391b
10e239b
fc8a3f8
5597cab
31189dc
40ba6c7
beb00b9
607f7ab
24310bd
ed3d8c0
8b557ab
ea0724b
d60d97d
1f0524e
87518d4
da7850a
b7f00c5
fac858d
c064626
3924dfd
5365204
1483a41
c8294b6
52aa231
798dc5e
e181864
0cca933
69179e6
a2f9b65
4d11ab6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This concerns me. I'd not do it in data plugin for the same reasons why we are not managing URL from a data plugin (filters, timeRange, refreshInterval).
I think instead apps should explicitly handle it.
Maybe we could introduce a
dev
warning, to check here if session wasn't cleaned on app unmount.But I am not sure that we should
clear()
here ourselves.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more question here ^^
@lizozom, what do you think? I think discover should handle this when navigating outside of discover?