[Enterprise Search] Update config data endpoint to v2 #76970
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ interface IReturn extends IInitialAppData { | |
| * useful various settings (e.g. product access, external URL) | ||
| * needed by the Kibana plugin at the setup stage | ||
| */ | ||
| const ENDPOINT = '/api/ent/v2/internal/client_config'; | ||
|
|
||
| export const callEnterpriseSearchConfigAPI = async ({ | ||
| config, | ||
|
|
@@ -67,44 +67,60 @@ export const callEnterpriseSearchConfigAPI = async ({ | |
| publicUrl: stripTrailingSlash(data?.settings?.external_url), | ||
| readOnlyMode: !!data?.settings?.read_only_mode, | ||
| ilmEnabled: !!data?.settings?.ilm_enabled, | ||
| isFederatedAuth: !!data?.settings?.is_federated_auth, // i.e., not standard auth | ||
| configuredLimits: { | ||
| appSearch: { | ||
| engine: { | ||
| maxDocumentByteSize: | ||
| data?.settings?.configured_limits?.app_search?.engine?.document_size_in_bytes, | ||
| maxEnginesPerMetaEngine: | ||
| data?.settings?.configured_limits?.app_search?.engine?.source_engines_per_meta_engine, | ||
| }, | ||
| }, | ||
|
Comment on lines
+72
to
+79
There was a problem hiding this comment. Note to self: There's a couple other configured limits for App Search that Bmac added to this endpoint:
I left them out for now because the App Search UI doesn't indicate using/displaying those values (at least in AppLogic), but they're there if we ever need to ✨ |
||
| workplaceSearch: { | ||
| customApiSource: { | ||
| maxDocumentByteSize: | ||
| data?.settings?.configured_limits?.workplace_search?.custom_api_source | ||
| ?.document_size_in_bytes, | ||
| totalFields: | ||
| data?.settings?.configured_limits?.workplace_search?.custom_api_source?.total_fields, | ||
| }, | ||
| }, | ||
|
Comment on lines
+80
to
+88
There was a problem hiding this comment. @scottybollinger Not sure if Workplace Search actually uses this configured limit data anywhere in the UI but I figured I might as well add it! |
||
| }, | ||
| appSearch: { | ||
| accountId: data?.current_user?.app_search?.account?.id, | ||
| onBoardingComplete: !!data?.current_user?.app_search?.account?.onboarding_complete, | ||
| role: { | ||
| id: data?.current_user?.app_search?.role?.id, | ||
| roleType: data?.current_user?.app_search?.role?.role_type, | ||
| ability: { | ||
| accessAllEngines: !!data?.current_user?.app_search?.role?.ability?.access_all_engines, | ||
| destroy: data?.current_user?.app_search?.role?.ability?.destroy || [], | ||
| manage: data?.current_user?.app_search?.role?.ability?.manage || [], | ||
| edit: data?.current_user?.app_search?.role?.ability?.edit || [], | ||
| view: data?.current_user?.app_search?.role?.ability?.view || [], | ||
| credentialTypes: data?.current_user?.app_search?.role?.ability?.credential_types || [], | ||
| availableRoleTypes: | ||
| data?.current_user?.app_search?.role?.ability?.available_role_types || [], | ||
| }, | ||
| }, | ||
| }, | ||
| workplaceSearch: { | ||
| organization: { | ||
| name: data?.current_user?.workplace_search?.organization?.name, | ||
| defaultOrgName: data?.current_user?.workplace_search?.organization?.default_org_name, | ||
| }, | ||
| account: { | ||
|
There was a problem hiding this comment. @scottybollinger - FYI, Brian renamed That being said, this change only affects the initial data/config endpoint & doesn't preclude you from using |
||
| id: data?.current_user?.workplace_search?.account?.id, | ||
| groups: data?.current_user?.workplace_search?.account?.groups || [], | ||
| isAdmin: !!data?.current_user?.workplace_search?.account?.is_admin, | ||
| canCreatePersonalSources: !!data?.current_user?.workplace_search?.account | ||
| ?.can_create_personal_sources, | ||
| canCreateInvitations: !!data?.current_user?.workplace_search?.account | ||
|
There was a problem hiding this comment. @scottybollinger FYI - |
||
| ?.can_create_invitations, | ||
| isCurated: !!data?.current_user?.workplace_search?.account?.is_curated, | ||
| viewedOnboardingPage: !!data?.current_user?.workplace_search?.account | ||
| ?.viewed_onboarding_page, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brian moved this to a top-level setting, not just nested under a Workplace Search specific key - I agree with him in this case since it affects both AS & WS.
So just an FYI @scottybollinger that the location of
isFederatedAuthhas moved, if that's okay