Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add metrics app to check made for internal custom URLs #77627

Merged
merged 1 commit into from
Sep 17, 2020
Merged

[ML] Add metrics app to check made for internal custom URLs #77627

merged 1 commit into from
Sep 17, 2020

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Sep 16, 2020 •
edited
Loading

Summary

Follow-up to #76460, fixing custom URLs when linking from an anomaly to the Metrics app, so that they are treated as 'kibana' URLs when building the actual URL to open from the url_value configured in the job.

image

Checklist

@peteharverson peteharverson added review :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 16, 2020
@peteharverson peteharverson requested a review from a team as a code owner September 16, 2020 15:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.0MB +99.0B 8.0MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov
darnautov approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 5419eeb into elastic:master Sep 17, 2020
@peteharverson peteharverson deleted the ml-metrics-custom-url branch September 17, 2020 08:56
@peteharverson peteharverson mentioned this pull request Sep 17, 2020
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Sep 17, 2020
@peteharverson
[ML] Add metrics app to check made for internal custom URLs (elastic#…
d604754 
…77627)
peteharverson added a commit that referenced this pull request Sep 17, 2020
@peteharverson
[ML] Add metrics app to check made for internal custom URLs (#77627) (#…
d54706b 
…77726)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
6a85bac 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov darnautov approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @kibanamachine @darnautov @jgowdyelastic