-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more specific rule skipping for a11y tests #77647
Conversation
6f9ac3c
to
22aaebd
Compare
58f539b
to
e3b6d3f
Compare
@elasticmachine merge upstream |
ee9bf57
to
167f77d
Compare
@elastic/kibana-app I removed the @elastic/kibana-app-arch I'm guessing y'all own the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for these awesome changes @myasonik MOAR TESTS
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana app team code review only, LGTM!
Summary
exclude
array (which excludes all rule testing) and migrated it to more granular per-rule exclusionsTeam details
@elastic/kibana-app I removed the role="menu" and role="menuitem" pieces because the roles weren't properly implemented (at least from a glance, missing keyboard controls and incorrect DOM structure. maybe other issues). It's debatable whether or not menu was ever right but it being broken would definitely cause more trouble than any value it could bring. The DOM without it is fine (a list of buttons).
@elastic/kibana-app-arch I'm guessing y'all own the query_string_input which I'm excluding from a specific set test because I'm assuming there's an eventual goal to replace that whole component with EUI. If not, I can create a ticket for fixing it.