-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Add helpers for flash messages #77677
Merged
scottybollinger
merged 7 commits into
elastic:master
from
scottybollinger:scottybollinger/success-message
Sep 16, 2020
Merged
[Enterprise Search] Add helpers for flash messages #77677
scottybollinger
merged 7 commits into
elastic:master
from
scottybollinger:scottybollinger/success-message
Sep 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
Feature:Plugins
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
labels
Sep 16, 2020
cee-chen
reviewed
Sep 16, 2020
...gins/enterprise_search/public/applications/shared/flash_messages/set_message_helpers.test.ts
Outdated
Show resolved
Hide resolved
scottybollinger
changed the title
[Enterprise Search] Add a helper for success messages
[Enterprise Search] Add a helpers for flash messages
Sep 16, 2020
cee-chen
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
scottybollinger
changed the title
[Enterprise Search] Add a helpers for flash messages
[Enterprise Search] Add helpers for flash messages
Sep 16, 2020
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Sep 16, 2020
* [Enterprise Search] Add a helper for success messages * Move method to separate file * Update test names * D R Y * I really need to slow down 🤦🏼♂️ * PR feedback * Typo
scottybollinger
added a commit
that referenced
this pull request
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the current FlashMessages implementation, the setting of a simple message is quite verbose. This PR exposes simple methods that set single-string messages, which covers most use cases in the logic files.
Before
After
Checklist