Add deprecated message to tile_map and region_map visualizations. #77683

nreese · 2020-09-16T21:52:26Z

This PR adds deprecated message to tile_map and region_map visualizations letting users know that tile_map and region_map will be replaced by Maps in 8.0.

To test, add xpack.maps.showMapVisualizationTypes: true to your kibana.dev.yml to create new tile_map and region_map visualizations.

The messaging focuses on the transition rather than removal. The notice contains a "View in Maps" button that migrates the existing configuration to Maps. When clicked, the tile_map configuration is migrated to Maps. The new map is not a one for one since Maps uses geotile_grid agg instead of geohash_agg but it at least gets the user off to a better start then nothing. These utilities created in this PR lay the foundation for an upgrade assistant to upgrade tile_map and region_map visualization saved objects to maps saved objects.

Deprecation message asks users to upgrade to default distro when Maps is not available.

…essage

elasticmachine · 2020-09-16T21:52:28Z

Pinging @elastic/kibana-gis (Team:Geo)

lukeelmers

Code review only; app arch changes LGTM

nreese · 2020-09-18T18:26:03Z

@elasticmachine merge upstream

nreese · 2020-09-18T18:38:42Z

@gchaps @kmartastic

Tagging you for copy review on PR. The PR adds deprecation message to tile_map and region_map visualization. The messaging focuses on the transition rather than removal.

When Maps is not installed message is
"Coordinate Map will migrate to Maps in 8.0. With Maps, you can add multiple layers and indices, plot individual documents, symbolize features from data values, and more. To get Maps, upgrade to the default distribution of Elasticsearch and Kibana."

When Maps is installed message is
"Coordinate Map will migrate to Maps in 8.0. With Maps, you can add multiple layers and indices, plot individual documents, symbolize features from data values, and more. View in Maps" where "View in Maps" is a button label.

Please provide any required updates.

kmartastic · 2020-09-18T20:32:26Z

@nreese

When Maps is not installed message is
"Coordinate Map will migrate to Maps in 8.0. With Maps, you can add multiple layers and indices, plot individual documents, symbolize features from data values, and more. To get Maps, upgrade to the default distribution of Elasticsearch and Kibana."

When Maps is installed message is
"Coordinate Map will migrate to Maps in 8.0. With Maps, you can add multiple layers and indices, plot individual documents, symbolize features from data values, and more. View in Maps" where "View in Maps" is a button label.

Please provide any required updates.

I like adding just a little more detail to the message. Keeping the last sentence as-is for each scenario.

Recommendation: "Coordinate Map will migrate to Maps in 8.0. With Maps, you can add multiple layers and indices, plot individual documents, add heatmaps, grids, and clusters, symbolize features from data values, and more. ...

thomasneirynck

there's a small edge-case due to how ids changed in EMS.

It's possible older saved-objects (pre 7.x) use older ids from EMS.

Rather than using .id, use .layerId.

The ems-client should correctly resolve that id to the layer.

e.g.: this is an old region-map from the ecommerce dataset.

{"attributes":{"fieldFormatMap":"{\"taxful_total_price\":{\"id\":\"number\",\"params\":{\"parsedUrl\":{\"origin\":\"http://localhost:5601\",\"pathname\":\"/cyl/app/discover\",\"basePath\":\"/cyl\"},\"pattern\":\"$0,0.[00]\"}}}","fields":"[{\"count\":0,\"name\":\"_id\",\"type\":\"string\",\"esTypes\":[\"_id\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":false},{\"count\":0,\"name\":\"_index\",\"type\":\"string\",\"esTypes\":[\"_index\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":false},{\"count\":0,\"name\":\"_score\",\"type\":\"number\",\"scripted\":false,\"searchable\":false,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"_source\",\"type\":\"_source\",\"esTypes\":[\"_source\"],\"scripted\":false,\"searchable\":false,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"_type\",\"type\":\"string\",\"esTypes\":[\"_type\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":false},{\"count\":0,\"name\":\"category\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"category.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"category\"}}},{\"count\":0,\"name\":\"currency\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"customer_birth_date\",\"type\":\"date\",\"esTypes\":[\"date\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"customer_first_name\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"customer_first_name.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"customer_first_name\"}}},{\"count\":0,\"name\":\"customer_full_name\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"customer_full_name.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"customer_full_name\"}}},{\"count\":0,\"name\":\"customer_gender\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"customer_id\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"customer_last_name\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"customer_last_name.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"customer_last_name\"}}},{\"count\":0,\"name\":\"customer_phone\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"day_of_week\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"day_of_week_i\",\"type\":\"number\",\"esTypes\":[\"integer\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"email\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"event.dataset\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"geoip.city_name\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"geoip.continent_name\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"geoip.country_iso_code\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":1,\"name\":\"geoip.location\",\"type\":\"geo_point\",\"esTypes\":[\"geo_point\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"geoip.region_name\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"manufacturer\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"manufacturer.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"manufacturer\"}}},{\"count\":0,\"name\":\"order_date\",\"type\":\"date\",\"esTypes\":[\"date\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"order_id\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products._id\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"products._id.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"products._id\"}}},{\"count\":0,\"name\":\"products.base_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.base_unit_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.category\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"products.category.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"products.category\"}}},{\"count\":0,\"name\":\"products.created_on\",\"type\":\"date\",\"esTypes\":[\"date\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.discount_amount\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.discount_percentage\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.manufacturer\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"products.manufacturer.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"products.manufacturer\"}}},{\"count\":0,\"name\":\"products.min_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.product_id\",\"type\":\"number\",\"esTypes\":[\"long\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.product_name\",\"type\":\"string\",\"esTypes\":[\"text\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":false,\"readFromDocValues\":false},{\"count\":0,\"name\":\"products.product_name.keyword\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true,\"subType\":{\"multi\":{\"parent\":\"products.product_name\"}}},{\"count\":0,\"name\":\"products.quantity\",\"type\":\"number\",\"esTypes\":[\"integer\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.sku\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.tax_amount\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.taxful_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.taxless_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"products.unit_discount_amount\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"sku\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"taxful_total_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"taxless_total_price\",\"type\":\"number\",\"esTypes\":[\"half_float\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"total_quantity\",\"type\":\"number\",\"esTypes\":[\"integer\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"total_unique_products\",\"type\":\"number\",\"esTypes\":[\"integer\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"type\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true},{\"count\":0,\"name\":\"user\",\"type\":\"string\",\"esTypes\":[\"keyword\"],\"scripted\":false,\"searchable\":true,\"aggregatable\":true,\"readFromDocValues\":true}]","timeFieldName":"order_date","title":"kibana_sample_data_ecommerce"},"id":"ff959d40-b880-11e8-a6d9-e546fe2bba5f","migrationVersion":{"index-pattern":"7.6.0"},"references":[],"type":"index-pattern","updated_at":"2020-08-27T17:51:31.088Z","version":"WzcwLDFd"}
{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"title":"[eCommerce] Average Sales Per Region","uiStateJSON":"{}","version":1,"visState":"{\"title\":\"[eCommerce] Average Sales Per Region\",\"type\":\"region_map\",\"params\":{\"legendPosition\":\"bottomright\",\"addTooltip\":true,\"colorSchema\":\"Blues\",\"selectedLayer\":{\"attribution\":\"<p><a href=\\\"http://www.naturalearthdata.com/about/terms-of-use\\\">Made with NaturalEarth</a>|<a href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a></p>&#10;\",\"weight\":1,\"name\":\"World Countries\",\"url\":\"https://vector.maps.elastic.co/blob/5659313586569216?elastic_tile_service_tos=agree&my_app_version=7.0.0-alpha1&license=f6c534b8-91b9-4499-8804-a2e9789ecc95\",\"format\":{\"type\":\"geojson\"},\"fields\":[{\"name\":\"iso2\",\"description\":\"Two letter abbreviation\"},{\"name\":\"name\",\"description\":\"Country name\"},{\"name\":\"iso3\",\"description\":\"Three letter abbreviation\"}],\"created_at\":\"2017-04-26T17:12:15.978370\",\"tags\":[],\"id\":5659313586569216,\"layerId\":\"elastic_maps_service.World Countries\",\"isEMS\":true},\"emsHotLink\":\"https://maps.elastic.co/v2#file/World Countries\",\"selectedJoinField\":{\"name\":\"iso2\",\"description\":\"Two letter abbreviation\"},\"isDisplayWarning\":true,\"wms\":{\"enabled\":false,\"options\":{\"format\":\"image/png\",\"transparent\":true}},\"mapZoom\":2,\"mapCenter\":[0,0],\"outlineWeight\":1,\"showAllShapes\":true},\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"avg\",\"schema\":\"metric\",\"params\":{\"field\":\"taxful_total_price\",\"customLabel\":\"Average Sale\"}},{\"id\":\"2\",\"enabled\":true,\"type\":\"terms\",\"schema\":\"segment\",\"params\":{\"field\":\"geoip.country_iso_code\",\"size\":100,\"order\":\"desc\",\"orderBy\":\"1\",\"otherBucket\":false,\"otherBucketLabel\":\"Other\",\"missingBucket\":false,\"missingBucketLabel\":\"Missing\"}}]}"},"id":"9c6f83f0-bb4d-11e8-9c84-77068524bcab","migrationVersion":{"visualization":"7.10.0"},"references":[{"id":"ff959d40-b880-11e8-a6d9-e546fe2bba5f","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"visualization","updated_at":"2020-08-27T17:51:11.500Z","version":"WzYxNSwxXQ=="}
{"exportedCount":2,"missingRefCount":0,"missingReferences":[]}

nreese · 2020-09-23T19:04:54Z

there's a small edge-case due to how ids changed in EMS.

Thanks for pointing this out. I have added a new function to pull the EMS id from layerId when id is a number

nreese · 2020-09-24T18:46:58Z

@elasticmachine merge upstream

nreese · 2020-09-24T20:54:54Z

@elasticmachine merge upstream

nreese · 2020-09-24T23:27:43Z

@elasticmachine merge upstream

nreese · 2020-09-25T00:25:42Z

@elasticmachine merge upstream

x-pack/plugins/maps/public/classes/layers/create_tile_map_layer_descriptor.ts

thomasneirynck

verified the edge-case fix works well, thx!

I highlighted two scoping issues. I don't feel strongly either way, so at your discretion.

x-pack/plugins/maps/public/classes/layers/create_tile_map_layer_descriptor.ts

kibanamachine · 2020-09-28T17:25:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 30f0772

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
maps	738	+2	736
mapsLegacy	186	+1	185
regionMap	15	+1	14
tileMap	21	+1	20
total		+5

async chunks size

id	value	diff	baseline
maps	3.3MB	+8.5KB	3.3MB
mapsLegacy	731.3KB	+1.0B	731.3KB
visualize	271.9KB	+711.0B	271.2KB
total		+9.2KB

page load bundle size

id	value	diff	baseline
maps	164.4KB	+5.6KB	158.8KB
mapsLegacy	99.6KB	+3.1KB	96.5KB
regionMap	49.9KB	+5.0KB	44.9KB
tileMap	49.1KB	+4.2KB	44.9KB
visualizations	272.7KB	+194.0B	272.5KB
total		+18.1KB

History

💔 Build #77439 failed a17b91e
💔 Build #77398 failed 18af546
💚 Build #77170 succeeded 83d5b45
💔 Build #77130 failed c7b4611
💔 Build #77079 failed d8dcbb4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…astic#77683) * Add deprecation message to coordinate map and region map * clean up text * add default distro link and view in maps link * move url generation into onClick handler * create tile map layer descritor * set metrics and color and scaling * lazy load createTileMapLayerDescriptor * tslint fixes * tslint cleanup for OSS code * add region map deprecation message * tslint cleanup * consolidate logic into LegacyMapDeprecationMessage * fix jest test * fix tile-map and region_map in OSS distro * tslint fixes * assert urlGenerator exists * update message text * ensure legacy-ids get correctly evaluated (#37) * handle 6.x region map saved objects * turn off field meta * fix type Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Thomas Neirynck <thomas@elastic.co> # Conflicts: # src/plugins/visualizations/public/vis_types/base_vis_type.ts

* master: Fix APM lodash imports (elastic#78438) Add deprecated message to tile_map and region_map visualizations. (elastic#77683) Fix Lens smokescreen flaky tests (elastic#78566) updated discover with alt text (elastic#77660) Fix types (elastic#78619) Update tutorial-visualizing.asciidoc (elastic#76977) Update tutorial-discovering.asciidoc (elastic#76976) [Search] Error notification alignment (elastic#77788) Update tutorial-define-index.asciidoc (elastic#76975) [Lens] Fieldless operations (elastic#78080) [Usage Collection] [schema] Explicit "array" definition (elastic#78141) Update tutorial-define-index.asciidoc (elastic#76973) Fix --no-basepath references in doc (elastic#78570) Move StubIndexPattern to data plugin and convert to TS. (elastic#78518) Index pattern class - remove unused methods (elastic#78538) [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523) [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773) First stab at developer-focussed saved objects docs (elastic#71430) remove unnecessary config validations (elastic#78527)

…astic#77683) * Add deprecation message to coordinate map and region map * clean up text * add default distro link and view in maps link * move url generation into onClick handler * create tile map layer descritor * set metrics and color and scaling * lazy load createTileMapLayerDescriptor * tslint fixes * tslint cleanup for OSS code * add region map deprecation message * tslint cleanup * consolidate logic into LegacyMapDeprecationMessage * fix jest test * fix tile-map and region_map in OSS distro * tslint fixes * assert urlGenerator exists * update message text * ensure legacy-ids get correctly evaluated (elastic#37) * handle 6.x region map saved objects * turn off field meta * fix type Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Thomas Neirynck <thomas@elastic.co>

…s. (#77683) (#78651) * Add deprecated message to tile_map and region_map visualizations. (#77683) * Add deprecation message to coordinate map and region map * clean up text * add default distro link and view in maps link * move url generation into onClick handler * create tile map layer descritor * set metrics and color and scaling * lazy load createTileMapLayerDescriptor * tslint fixes * tslint cleanup for OSS code * add region map deprecation message * tslint cleanup * consolidate logic into LegacyMapDeprecationMessage * fix jest test * fix tile-map and region_map in OSS distro * tslint fixes * assert urlGenerator exists * update message text * ensure legacy-ids get correctly evaluated (#37) * handle 6.x region map saved objects * turn off field meta * fix type Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Thomas Neirynck <thomas@elastic.co> # Conflicts: # src/plugins/visualizations/public/vis_types/base_vis_type.ts * fix eslint error

nreese added 6 commits September 14, 2020 15:33

Add deprecation message to coordinate map and region map

a3946de

clean up text

bbf755f

Merge branch 'master' of github.com:elastic/kibana into deprecation_m…

1e672ad

…essage

add default distro link and view in maps link

1b5a900

move url generation into onClick handler

7571e3d

create tile map layer descritor

7ab105b

nreese added release_note:enhancement WIP Work in progress [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.10.0 labels Sep 16, 2020

nreese requested a review from a team September 16, 2020 21:52

nreese requested review from a team as code owners September 16, 2020 21:52

lukeelmers approved these changes Sep 16, 2020

View reviewed changes

nreese added 7 commits September 17, 2020 09:20

set metrics and color and scaling

a18083c

lazy load createTileMapLayerDescriptor

820acb3

tslint fixes

c9fa756

tslint cleanup for OSS code

45d587b

add region map deprecation message

4ba5d75

tslint cleanup

1183845

consolidate logic into LegacyMapDeprecationMessage

df9bb6a

Merge branch 'master' into deprecation_message

2b081d7

nreese added review and removed WIP Work in progress labels Sep 18, 2020

fix jest test

a75891a

thomasneirynck reviewed Sep 23, 2020

View reviewed changes

thomasneirynck and others added 2 commits September 23, 2020 12:11

ensure legacy-ids get correctly evaluated (#37)

8728dca

handle 6.x region map saved objects

e7ce0e0

nreese requested a review from thomasneirynck September 23, 2020 19:04

Merge branch 'master' into deprecation_message

d8dcbb4

Merge branch 'master' into deprecation_message

c7b4611

Merge branch 'master' into deprecation_message

83d5b45

thomasneirynck reviewed Sep 25, 2020

View reviewed changes

x-pack/plugins/maps/public/classes/layers/create_tile_map_layer_descriptor.ts Show resolved Hide resolved

thomasneirynck approved these changes Sep 25, 2020

View reviewed changes

x-pack/plugins/maps/public/classes/layers/create_tile_map_layer_descriptor.ts Show resolved Hide resolved

x-pack/plugins/maps/public/classes/layers/create_tile_map_layer_descriptor.ts Show resolved Hide resolved

nreese added 4 commits September 28, 2020 07:42

merge with master

18af546

turn off field meta

030986b

fix type

a17b91e

merge with master

30f0772

nreese merged commit 54a2c75 into elastic:master Sep 28, 2020

nreese mentioned this pull request Sep 28, 2020

[7.x] Add deprecated message to tile_map and region_map visualizations. (#77683) #78651

Merged

timroes mentioned this pull request Sep 29, 2020

Remove isDeprecated flag on visType #78820

Merged

nreese mentioned this pull request Sep 30, 2020

Timeline for removing legacy maps plugins #65520

Closed

alisonelizabeth mentioned this pull request Nov 18, 2020

[Breaking change] Remove Coordinate map and region map visualizations #81703

Closed

kindsun mentioned this pull request Mar 9, 2021

[Maps] Integrate "vega maps" functionality as a layer in the Maps app #94234

Closed

nreese mentioned this pull request Jul 13, 2021

[maps] saved object migration to migrate tile_map and region_map visualizations to maps #105115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deprecated message to tile_map and region_map visualizations. #77683

Add deprecated message to tile_map and region_map visualizations. #77683

nreese commented Sep 16, 2020 •

edited

Loading

elasticmachine commented Sep 16, 2020

lukeelmers left a comment

nreese commented Sep 18, 2020

nreese commented Sep 18, 2020

kmartastic commented Sep 18, 2020

thomasneirynck left a comment •

edited

Loading

nreese commented Sep 23, 2020

nreese commented Sep 24, 2020

nreese commented Sep 24, 2020

nreese commented Sep 24, 2020

nreese commented Sep 25, 2020

thomasneirynck left a comment

kibanamachine commented Sep 28, 2020

Add deprecated message to tile_map and region_map visualizations. #77683

Add deprecated message to tile_map and region_map visualizations. #77683

Conversation

nreese commented Sep 16, 2020 • edited Loading

elasticmachine commented Sep 16, 2020

lukeelmers left a comment

Choose a reason for hiding this comment

nreese commented Sep 18, 2020

nreese commented Sep 18, 2020

kmartastic commented Sep 18, 2020

thomasneirynck left a comment • edited Loading

Choose a reason for hiding this comment

nreese commented Sep 23, 2020

nreese commented Sep 24, 2020

nreese commented Sep 24, 2020

nreese commented Sep 24, 2020

nreese commented Sep 25, 2020

thomasneirynck left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 28, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

nreese commented Sep 16, 2020 •

edited

Loading

thomasneirynck left a comment •

edited

Loading