[Lens] adding some functional tests #77863
Conversation
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/functional_tests_debt
branch
from
6ed291a to
66a9f75
Compare
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
added
the
release_note:skip
| @@ -40,18 +40,21 @@ export default function ({ getPageObjects, getService }) { | |||
| operation: 'date_histogram', | |||
| field: '@timestamp', | |||
| }); | |||
| await PageObjects.lens.closeDimensionEditor(); | |||
There was a problem hiding this comment.
I suspect you had to put these because the flyout does not close on outside click?
There was a problem hiding this comment.
I actually removed the line that was closing the dimension from the configureDimension method:
https://github.com/elastic/kibana/pull/77863/files#diff-593978ac44529e71d36a3c038cb91c00R114
I was having doubts here – I've done it because in two cases here and here I want to keep modifying the dimension after configuring it so I've decided to not close it inside the method.
There was a problem hiding this comment.
Maybe the configureDimention could have a params object as argument to disable the closing of the panel? This will reduce a bit the code here and you would be still able to do things manually
There was a problem hiding this comment.
I'll merge it for now so the branch is not stale during my time off. Will address this in the next PR.
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
Summary
Another part of #72585
This PR adds the following tests:
I also removed the field testing the saved visualisation as it repeats the logic of 'should transition from metric to table to metric'.