[APM] Script static checkers + precommit #77900
Conversation
dgieselaar
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
| task: () => | ||
| execa( | ||
| 'node', | ||
| [ |
There was a problem hiding this comment.
Could we just do require.resolve('jest/bin/jest') here? Not sure what the jest script written here does other than run the CLI.
There was a problem hiding this comment.
Is that the same as running yarn jest --config x-pack/plugins/apm/jest.config.js? Because looks like the latter is a little slower to pick up files.
| resolve(__dirname, './jest.js'), | ||
| '--reporters', | ||
| resolve(__dirname, './node_modules/jest-silent-reporter'), | ||
| '--collect-coverage', |
There was a problem hiding this comment.
If this is just for precommit we might want to turn off coverage
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
| fix, | ||
| cache: true, | ||
| extensions: ['.js', '.jsx', '.ts', '.tsx'], | ||
| }); |
There was a problem hiding this comment.
Does this automatically find the right eslintrc?
|
|
||
| const config = require('../jest.config.js'); | ||
|
|
||
| const argv = [...process.argv.slice(2), '--config', JSON.stringify(config)]; |
There was a problem hiding this comment.
Looks like this could/should be a path
| const argv = [...process.argv.slice(2), '--config', JSON.stringify(config)]; | |
| const argv = [...process.argv.slice(2), '--config', '../jest.config.js']; |
(might have to do something with path.resolve('..', 'jest.config.js') to get the correct path)
There was a problem hiding this comment.
It's the same approach as the top-level jest test runner uses.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Adds a
precommitscript that can be used in.git/hooks/pre-commit.local. Also scripts Jest and ESLint runs. Those scripts are able to gather files more quickly, resulting in a performance boost.To run the scripts:
./x-pack/plugins/apm/scripts/precommit./x-pack/plugins/apm/scripts/jest./x-pack/plugins/apm/scripts/eslint