Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Embeddable telemetry and reference extraction/injection (#74352) #77911

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

ppisljar
Copy link
Member

Backports the following commits to 7.x:

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack APM API integration tests (basic).x-pack/test/apm_api_integration/basic/tests/metrics_charts/metrics_charts·ts.APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/77870

[00:00:00]       │
[00:00:00]         └-: APM specs (basic)
[00:00:00]           └-> "before all" hook
[00:01:53]           └-: Metrics
[00:01:53]             └-> "before all" hook
[00:01:53]             └-: when data is loaded
[00:01:53]               └-> "before all" hook
[00:01:53]               └-> "before all" hook
[00:01:53]                 │ info [metrics_8.0.0] Loading "mappings.json"
[00:01:53]                 │ info [metrics_8.0.0] Loading "data.json.gz"
[00:01:53]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1600444044347047698] [apm-8.0.0-metric-000001] creating index, cause [api], templates [], shards [1]/[0]
[00:01:54]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1600444044347047698] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[apm-8.0.0-metric-000001][0]]]).
[00:01:54]                 │ info [metrics_8.0.0] Created index "apm-8.0.0-metric-000001"
[00:01:54]                 │ debg [metrics_8.0.0] "apm-8.0.0-metric-000001" settings {"index":{"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-metric"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"0","number_of_shards":"1","priority":"100","refresh_interval":"1ms"}}
[00:01:54]                 │ info [metrics_8.0.0] Indexed 2323 docs into "apm-8.0.0-metric-000001"
[00:01:54]               └-: for opbeans-node
[00:01:54]                 └-> "before all" hook
[00:01:54]                 └-: returns metrics data
[00:01:54]                   └-> "before all" hook
[00:01:54]                   └-> "before all" hook
[00:01:55]                   └-> contains CPU usage and System memory usage chart data
[00:01:55]                     └-> "before each" hook: global before each
[00:01:55]                     └-> "before each" hook
[00:01:55]                     └- ✓ pass  (0ms) "APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data contains CPU usage and System memory usage chart data"
[00:01:55]                   └-> "after each" hook
[00:01:55]                   └-: CPU usage
[00:01:55]                     └-> "before all" hook
[00:01:55]                     └-> "before all" hook
[00:01:55]                     └-> has correct series
[00:01:55]                       └-> "before each" hook: global before each
[00:01:55]                       └-> "before each" hook
[00:01:55]                       └- ✓ pass  (0ms) "APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series"
[00:01:55]                     └-> "after each" hook
[00:01:55]                     └-> has correct series overall values
[00:01:55]                       └-> "before each" hook: global before each
[00:01:55]                       └-> "before each" hook
[00:01:55]                       └- ✖ fail: APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values
[00:01:55]                       │       Error: expect(received).toMatchInlineSnapshot(snapshot)
[00:01:55]                       │ 
[00:01:55]                       │ Snapshot name: `when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values 1`
[00:01:55]                       │ 
[00:01:55]                       │ - Snapshot  - 1
[00:01:55]                       │ + Received  + 1
[00:01:55]                       │ 
[00:01:55]                       │   Array [
[00:01:55]                       │     0.714,
[00:01:55]                       │ -   0.38770000000000004,
[00:01:55]                       │ +   0.3877,
[00:01:55]                       │     0.75,
[00:01:55]                       │     0.2543,
[00:01:55]                       │   ]
[00:01:55]                       │       + expected - actual
[00:01:55]                       │ 
[00:01:55]                       │       -false
[00:01:55]                       │       +true
[00:01:55]                       │       
[00:01:55]                       │       at Assertion.assert (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:100:11)
[00:01:55]                       │       at Assertion.toMatchInline [as eql] (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:244:8)
[00:01:55]                       │       at Context.apply (test/apm_api_integration/basic/tests/metrics_charts/metrics_charts.ts:69:16)
[00:01:55]                       │       at Object.apply (/dev/shm/workspace/parallel/7/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30)
[00:01:55]                       │ 
[00:01:55]                       │ 

Stack Trace

{ Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values 1`

- Snapshot  - 1
+ Received  + 1

  Array [
    0.714,
-   0.38770000000000004,
+   0.3877,
    0.75,
    0.2543,
  ]
    at Assertion.assert (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.toMatchInline [as eql] (/dev/shm/workspace/parallel/7/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.apply (test/apm_api_integration/basic/tests/metrics_charts/metrics_charts.ts:69:16)
    at Object.apply (/dev/shm/workspace/parallel/7/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30) actual: 'false', expected: 'true', showDiff: true }

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
embeddable 75 +3 72
kibanaUtils 190 +1 189
uiActionsEnhanced 278 +2 276
total +6

page load bundle size

id value diff baseline
embeddable 366.8KB +4.6KB 362.2KB
kibanaUtils 471.7KB +1.3KB 470.4KB
uiActionsEnhanced 380.1KB +561.0B 379.5KB
total +6.4KB

distributable file count

id value diff baseline
default 47634 +11 47623
oss 28343 +6 28337
total +17

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 84c7886 into elastic:7.x Sep 19, 2020
@ppisljar ppisljar deleted the backport/7.x/pr-74352 branch September 19, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants