Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] Js errors #77919

Merged
merged 28 commits into from
Sep 28, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
75fe1b6
update
shahzad31 Sep 13, 2020
bb6ed3e
Merge branch 'master' into impactful-metrics
shahzad31 Sep 14, 2020
e7cc20c
Merge branch 'master' into js-errors
shahzad31 Sep 17, 2020
42bf52a
added js errors table
shahzad31 Sep 18, 2020
601e96d
Merge branch 'master' into js-errors
shahzad31 Sep 18, 2020
cfb3d34
Merge branch 'master' into js-errors
shahzad31 Sep 21, 2020
1c1327a
fix types
shahzad31 Sep 21, 2020
29a007f
fix type
shahzad31 Sep 21, 2020
36e3684
update test
shahzad31 Sep 21, 2020
3440978
update test
shahzad31 Sep 21, 2020
b27daf8
update test
shahzad31 Sep 21, 2020
c32a55e
Merge branch 'master' into js-errors
shahzad31 Sep 22, 2020
758eab6
PR feedback
shahzad31 Sep 22, 2020
ccbbbed
improve local
shahzad31 Sep 22, 2020
f1735b7
Merge branch 'master' into js-errors
shahzad31 Sep 23, 2020
a1a0fb7
update i18n
shahzad31 Sep 23, 2020
222e542
Merge branch 'master' into js-errors
shahzad31 Sep 23, 2020
650d715
Merge branch 'master' into js-errors
shahzad31 Sep 23, 2020
895e87b
fix i18n
shahzad31 Sep 23, 2020
abb4a0c
improve test resiliance
shahzad31 Sep 23, 2020
28fcebc
Merge branch 'master' into js-errors
shahzad31 Sep 24, 2020
ec2e075
improve code ownership
shahzad31 Sep 24, 2020
866fabe
revert change
shahzad31 Sep 24, 2020
96599cf
Merge branch 'master' into js-errors
shahzad31 Sep 24, 2020
504888b
Merge branch 'master' into js-errors
elasticmachine Sep 28, 2020
8ff79f6
revert change
shahzad31 Sep 28, 2020
9d6e70f
fixed type
shahzad31 Sep 28, 2020
f80fe40
remove unnecessary title for now
shahzad31 Sep 28, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix types
  • Loading branch information
shahzad31 committed Sep 21, 2020
commit 1c1327abda97233e98f524162a80239ef94c77cb
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ export function CsmSharedContextProvider({
}) {
const [newData, setNewData] = useState<SharedData>({ totalPageViews: 0 });

const setSharedData = (data: SharedData) => {
const setSharedData = React.useCallback((data: SharedData) => {
setNewData(data);
};
}, []);

const value = useMemo(() => {
return { sharedData: newData, setSharedData };
}, [newData]);
}, [newData, setSharedData]);

return <CsmSharedContext.Provider value={value} children={children} />;
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { I18LABELS } from './translations';
import { VisitorBreakdown } from './VisitorBreakdown';
import { UXMetrics } from './UXMetrics';
import { VisitorBreakdownMap } from './VisitorBreakdownMap';
import { CoreVitals } from './CoreVitals';
import { ImpactfulMetrics } from './ImpactfulMetrics';

export function RumDashboard() {
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/apm/server/routes/create_apm_api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ import {
rumVisitorsBreakdownRoute,
rumWebCoreVitals,
rumJSErrors,
rumHighTrafficPages,
rumLongTaskMetrics,
} from './rum_client';
import {
Expand Down