Use new header icon badge for newsfeed button #77946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
added
v8.0.0
release_note:skip
cchaos
suggested changes
Sep 18, 2020
src/plugins/newsfeed/public/components/newsfeed_header_nav_button.tsx
Outdated
Show resolved
Hide resolved
cchaos
approved these changes
Sep 18, 2020
|
there's the related test 😬 |
ryankeairns
force-pushed
the
rk/newsfeed-badge
branch
from
d7a5ff5 to
14e2982
Compare
afharo
reviewed
Sep 21, 2020
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
myasonik
approved these changes
Sep 21, 2020
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Sep 21, 2020
* Use new header icon badge for newsfeed button * add i18n, fix flyout level * fix i18n namespace, fix badge test * update newfeed badge test
ryankeairns
added a commit
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With elastic/eui#4008 , a new badge design was added for cases where you don't need to display a count. Prior to this, we were using a 'dot' character.
Before
After
Checklist
N/A